Skip to content

Commit 3b6880d

Browse files
authored
Merge pull request moby#4472 from milas/v0.12-otel-resource
tracing: allow the `Resource` to be set externally
2 parents 833949d + 7b3fe03 commit 3b6880d

File tree

1 file changed

+16
-8
lines changed

1 file changed

+16
-8
lines changed

util/tracing/detect/detect.go

Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,8 @@ type detector struct {
2626
var ServiceName string
2727
var Recorder *TraceRecorder
2828

29+
var Resource *resource.Resource
30+
2931
var detectors map[string]detector
3032
var once sync.Once
3133
var tp trace.TracerProvider
@@ -97,13 +99,16 @@ func detect() error {
9799
// enable log with traceID when valid exporter
98100
bklog.EnableLogWithTraceID(true)
99101

100-
res, err := resource.Detect(context.Background(), serviceNameDetector{})
101-
if err != nil {
102-
return err
103-
}
104-
res, err = resource.Merge(resource.Default(), res)
105-
if err != nil {
106-
return err
102+
if Resource == nil {
103+
res, err := resource.Detect(context.Background(), serviceNameDetector{})
104+
if err != nil {
105+
return err
106+
}
107+
res, err = resource.Merge(resource.Default(), res)
108+
if err != nil {
109+
return err
110+
}
111+
Resource = res
107112
}
108113

109114
sp := sdktrace.NewBatchSpanProcessor(exp)
@@ -112,7 +117,10 @@ func detect() error {
112117
Recorder.flush = sp.ForceFlush
113118
}
114119

115-
sdktp := sdktrace.NewTracerProvider(sdktrace.WithSpanProcessor(sp), sdktrace.WithResource(res))
120+
sdktp := sdktrace.NewTracerProvider(
121+
sdktrace.WithSpanProcessor(sp),
122+
sdktrace.WithResource(Resource),
123+
)
116124
closers = append(closers, sdktp.Shutdown)
117125

118126
exporter = exp

0 commit comments

Comments
 (0)