Merge pull request moby#3938 from alexcb/lock-list-mu-before-accessing-actives

tonistiigi · web-flow · commit 3c4e8f59599d · 2023-06-08T15:33:33.000-07:00
solver: lock before using actives
diff --git a/solver/jobs.go b/solver/jobs.go
@@ -533,6 +533,8 @@ func (wp *withProvenance) WalkProvenance(ctx context.Context, f func(ProvenanceP
 	if wp.j == nil {
 		return nil
 	}
+	wp.j.list.mu.RLock()
+	defer wp.j.list.mu.RUnlock()
 	m := map[digest.Digest]struct{}{}
 	return wp.j.walkProvenance(ctx, wp.e, f, m)
 }

Original file line number	Diff line number	Diff line change
`@@ -533,6 +533,8 @@ func (wp *withProvenance) WalkProvenance(ctx context.Context, f func(ProvenanceP`
`533`	`533`	`if wp.j == nil {`
`534`	`534`	`return nil`
`535`	`535`	`}`
	`536`	`+ wp.j.list.mu.RLock()`
	`537`	`+ defer wp.j.list.mu.RUnlock()`
`536`	`538`	`m := map[digest.Digest]struct{}{}`
`537`	`539`	`return wp.j.walkProvenance(ctx, wp.e, f, m)`
`538`	`540`	`}`