Skip to content

Commit 3f86f92

Browse files
authored
Merge pull request moby#4543 from thaJeztah/0.12_alpine_version_buildarg
[0.12 backport] hack/test: allow ALPINE_VERSION to be set from env
2 parents bcee605 + be957c5 commit 3f86f92

File tree

2 files changed

+24
-20
lines changed

2 files changed

+24
-20
lines changed

hack/images

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@ PUSH=$3
77
. $(dirname $0)/util
88
set -eu -o pipefail
99

10-
: ${RELEASE=false}
11-
: ${PLATFORMS=}
12-
: ${TARGET=}
10+
: "${RELEASE=false}"
11+
: "${PLATFORMS=}"
12+
: "${TARGET=}"
1313

1414
versionTag=$(git describe --always --tags --match "v[0-9]*")
1515

hack/test

Lines changed: 21 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -3,23 +3,26 @@
33
. $(dirname $0)/util
44
set -eu -o pipefail
55

6-
: ${GO_VERSION=}
7-
: ${HTTP_PROXY=}
8-
: ${HTTPS_PROXY=}
9-
: ${NO_PROXY=}
10-
: ${TEST_INTEGRATION=}
11-
: ${TEST_GATEWAY=}
12-
: ${TEST_DOCKERFILE=}
13-
: ${TEST_DOCKERD=}
14-
: ${TEST_DOCKERD_BINARY=$(which dockerd)}
15-
: ${TEST_REPORT_SUFFIX=}
16-
: ${TEST_KEEP_CACHE=}
17-
: ${GOBUILDFLAGS=}
18-
: ${VERIFYFLAGS=}
19-
: ${CGO_ENABLED=}
20-
: ${DOCKERFILE_RELEASES=}
21-
: ${BUILDKIT_WORKER_RANDOM=}
22-
: ${BUILDKITD_TAGS=}
6+
: "${ALPINE_VERSION=}"
7+
: "${GO_VERSION=}"
8+
: "${HTTP_PROXY=}"
9+
: "${HTTPS_PROXY=}"
10+
: "${NO_PROXY=}"
11+
12+
: "${TEST_INTEGRATION=}"
13+
: "${TEST_GATEWAY=}"
14+
: "${TEST_DOCKERFILE=}"
15+
: "${TEST_DOCKERD=}"
16+
: "${TEST_DOCKERD_BINARY=$(which dockerd)}"
17+
: "${TEST_REPORT_SUFFIX=}"
18+
: "${TEST_KEEP_CACHE=}"
19+
20+
: "${GOBUILDFLAGS=}"
21+
: "${VERIFYFLAGS=}"
22+
: "${CGO_ENABLED=}"
23+
: "${DOCKERFILE_RELEASES=}"
24+
: "${BUILDKIT_WORKER_RANDOM=}"
25+
: "${BUILDKITD_TAGS=}"
2326

2427
if [ "$TEST_DOCKERD" == "1" ]; then
2528
if [ ! -f "$TEST_DOCKERD_BINARY" ]; then
@@ -75,6 +78,7 @@ if [[ "$GOBUILDFLAGS" == *"-race"* ]]; then
7578
fi
7679

7780
buildxCmd build $cacheFromFlags \
81+
--build-arg ALPINE_VERSION \
7882
--build-arg GO_VERSION \
7983
--build-arg BUILDKITD_TAGS \
8084
--build-arg HTTP_PROXY \

0 commit comments

Comments
 (0)