Disallow ADD --checksum=<SUM> <GITSRC> <DST>

AkihiroSuda · AkihiroSuda · commit 6b445634ed5b · 2024-06-25T16:47:15.000+09:00
Discussed in a comment in PR 5064

Signed-off-by: Akihiro Suda &lt;akihiro.suda.cz@hco.ntt.co.jp&gt;
diff --git a/frontend/dockerfile/dockerfile2llb/convert.go b/frontend/dockerfile/dockerfile2llb/convert.go
@@ -2117,7 +2117,14 @@ func commonImageNames() []string {
 }
 
 func isHTTPSource(src string) bool {
-	return strings.HasPrefix(src, "http://") || strings.HasPrefix(src, "https://")
+	if !strings.HasPrefix(src, "http://") && !strings.HasPrefix(src, "https://") {
+		return false
+	}
+	// https://github.com/ORG/REPO.git is a git source, not an http source
+	if gitRef, gitErr := gitutil.ParseGitRef(src); gitRef != nil && gitErr == nil {
+		return false
+	}
+	return true
 }
 
 func isEnabledForStage(stage string, value string) bool {

Original file line number	Diff line number	Diff line change
`@@ -2117,7 +2117,14 @@ func commonImageNames() []string {`
`2117`	`2117`	`}`
`2118`	`2118`
`2119`	`2119`	`func isHTTPSource(src string) bool {`
`2120`		`- return strings.HasPrefix(src, "http://") \|\| strings.HasPrefix(src, "https://")`
	`2120`	`+ if !strings.HasPrefix(src, "http://") && !strings.HasPrefix(src, "https://") {`
	`2121`	`+ return false`
	`2122`	`+ }`
	`2123`	`+ // https://github.com/ORG/REPO.git is a git source, not an http source`
	`2124`	`+ if gitRef, gitErr := gitutil.ParseGitRef(src); gitRef != nil && gitErr == nil {`
	`2125`	`+ return false`
	`2126`	`+ }`
	`2127`	`+ return true`
`2121`	`2128`	`}`
`2122`	`2129`
`2123`	`2130`	`func isEnabledForStage(stage string, value string) bool {`