Skip to content

Commit 707d84f

Browse files
committed
Drop unneeded variable
Signed-off-by: Seiya Miyata <[email protected]>
1 parent 9d35774 commit 707d84f

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

solver/llbsolver/solver.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ import (
3434
"github.com/moby/buildkit/util/progress"
3535
"github.com/moby/buildkit/util/tracing/detect"
3636
"github.com/moby/buildkit/worker"
37-
digest "github.com/opencontainers/go-digest"
37+
"github.com/opencontainers/go-digest"
3838
"github.com/pkg/errors"
3939
"go.opentelemetry.io/otel/sdk/trace/tracetest"
4040
"go.opentelemetry.io/otel/trace"
@@ -907,27 +907,27 @@ func inBuilderContext(ctx context.Context, b solver.Builder, name, id string, f
907907
}
908908
return b.InContext(ctx, func(ctx context.Context, g session.Group) error {
909909
pw, _, ctx := progress.NewFromContext(ctx, progress.WithMetadata("vertex", v.Digest))
910-
notifyCompleted := notifyStarted(ctx, &v, false)
910+
notifyCompleted := notifyStarted(ctx, &v)
911911
defer pw.Close()
912912
err := f(ctx, g)
913-
notifyCompleted(err, false)
913+
notifyCompleted(err)
914914
return err
915915
})
916916
}
917917

918-
func notifyStarted(ctx context.Context, v *client.Vertex, cached bool) func(err error, cached bool) {
918+
func notifyStarted(ctx context.Context, v *client.Vertex) func(err error) {
919919
pw, _, _ := progress.NewFromContext(ctx)
920920
start := time.Now()
921921
v.Started = &start
922922
v.Completed = nil
923-
v.Cached = cached
923+
v.Cached = false
924924
id := identity.NewID()
925925
pw.Write(id, *v)
926-
return func(err error, cached bool) {
926+
return func(err error) {
927927
defer pw.Close()
928928
stop := time.Now()
929929
v.Completed = &stop
930-
v.Cached = cached
930+
v.Cached = false
931931
if err != nil {
932932
v.Error = err.Error()
933933
}

0 commit comments

Comments
 (0)