Skip to content

Commit 73862d1

Browse files
committed
s3: rely on aws sdk v2 error types
Signed-off-by: CrazyMax <[email protected]>
1 parent d5a5df5 commit 73862d1

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

cache/remotecache/s3/s3.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import (
1515
"github.com/aws/aws-sdk-go-v2/credentials"
1616
"github.com/aws/aws-sdk-go-v2/feature/s3/manager"
1717
"github.com/aws/aws-sdk-go-v2/service/s3"
18-
"github.com/aws/smithy-go"
18+
s3types "github.com/aws/aws-sdk-go-v2/service/s3/types"
1919
"github.com/containerd/containerd/content"
2020
"github.com/containerd/containerd/labels"
2121
"github.com/moby/buildkit/cache/remotecache"
@@ -472,6 +472,7 @@ func (s3Client *s3Client) blobKey(dgst digest.Digest) string {
472472
}
473473

474474
func isNotFound(err error) bool {
475-
var errapi smithy.APIError
476-
return errors.As(err, &errapi) && (errapi.ErrorCode() == "NoSuchKey" || errapi.ErrorCode() == "NotFound")
475+
var nf *s3types.NotFound
476+
var nsk *s3types.NoSuchKey
477+
return errors.As(err, &nf) || errors.As(err, &nsk)
477478
}

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ require (
1414
github.com/aws/aws-sdk-go-v2/credentials v1.16.16
1515
github.com/aws/aws-sdk-go-v2/feature/s3/manager v1.15.15
1616
github.com/aws/aws-sdk-go-v2/service/s3 v1.48.1
17-
github.com/aws/smithy-go v1.19.0
1817
github.com/containerd/console v1.0.3
1918
github.com/containerd/containerd v1.7.12
2019
github.com/containerd/continuity v0.4.2
@@ -123,6 +122,7 @@ require (
123122
github.com/aws/aws-sdk-go-v2/service/sso v1.18.7 // indirect
124123
github.com/aws/aws-sdk-go-v2/service/ssooidc v1.21.7 // indirect
125124
github.com/aws/aws-sdk-go-v2/service/sts v1.26.7 // indirect
125+
github.com/aws/smithy-go v1.19.0 // indirect
126126
github.com/beorn7/perks v1.0.1 // indirect
127127
github.com/cenkalti/backoff/v4 v4.2.1 // indirect
128128
github.com/cespare/xxhash/v2 v2.2.0 // indirect

0 commit comments

Comments
 (0)