Skip to content

Commit 76945ca

Browse files
committed
llbsolver: make sure stoptrace called on bolt error
Signed-off-by: Tonis Tiigi <[email protected]>
1 parent 486d1ef commit 76945ca

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

solver/llbsolver/solver.go

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -180,6 +180,9 @@ func (s *Solver) recordBuildHistory(ctx context.Context, id string, req frontend
180180
Type: controlapi.BuildHistoryEventType_STARTED,
181181
Record: rec,
182182
}); err != nil {
183+
if stopTrace != nil {
184+
stopTrace()
185+
}
183186
return nil, err
184187
}
185188

@@ -377,9 +380,10 @@ func (s *Solver) recordBuildHistory(ctx context.Context, id string, req frontend
377380
}()
378381

379382
if err != nil {
380-
status, desc, release, err := s.history.ImportError(ctx, err)
381-
if err != nil {
382-
return err
383+
status, desc, release, err1 := s.history.ImportError(ctx, err)
384+
if err1 != nil {
385+
// don't replace the build error with this import error
386+
bklog.G(ctx).Errorf("failed to import error to build record: %+v", err1)
383387
}
384388
rec.ExternalError = desc
385389
releasers = append(releasers, release)

0 commit comments

Comments
 (0)