Skip to content

Commit 9122e57

Browse files
authored
Merge pull request moby#3851 from sipsma/fix-usage-ref-leak
cache: always release ref when getting size in usage.
2 parents a0943c0 + f1223ed commit 9122e57

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

cache/manager.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1425,12 +1425,13 @@ func (cm *cacheManager) DiskUsage(ctx context.Context, opt client.DiskUsageInfo)
14251425
d.Size = 0
14261426
return nil
14271427
}
1428+
defer ref.Release(context.TODO())
14281429
s, err := ref.size(ctx)
14291430
if err != nil {
14301431
return err
14311432
}
14321433
d.Size = s
1433-
return ref.Release(context.TODO())
1434+
return nil
14341435
})
14351436
}(d)
14361437
}

0 commit comments

Comments
 (0)