progress: don't modify ResetTime inputs

No other parts of the progress rendering modify the inputs, so we should
avoid this as well.

This actually fixes an edge case in pushWithMoby which writes the same
VertexStatus multiple times, modifying the timestamps and similar.
However, if the operation takes long enough the small time difference
can accumulate, and move the Start time far into the past.

Signed-off-by: Justin Chadwell <[email protected]>

Author: jedevc

util/progress/progresswriter/reset.go

@@ -27,7 +27,9 @@ func ResetTime(in Writer) Writer {
 					}
 				}
 				if w.diff != nil {
+					vertexes := make([]*client.Vertex, 0, len(st.Vertexes))
 					for _, v := range st.Vertexes {
+						v := *v
 						if v.Started != nil {
 							d := v.Started.Add(-*w.diff)
 							v.Started = &d
@@ -36,8 +38,12 @@ func ResetTime(in Writer) Writer {
 							d := v.Completed.Add(-*w.diff)
 							v.Completed = &d
 						}
+						vertexes = append(vertexes, &v)
 					}
+
+					statuses := make([]*client.VertexStatus, 0, len(st.Statuses))
 					for _, v := range st.Statuses {
+						v := *v
 						if v.Started != nil {
 							d := v.Started.Add(-*w.diff)
 							v.Started = &d
@@ -47,9 +53,21 @@ func ResetTime(in Writer) Writer {
 							v.Completed = &d
 						}
 						v.Timestamp = v.Timestamp.Add(-*w.diff)
+						statuses = append(statuses, &v)
 					}
+
+					logs := make([]*client.VertexLog, 0, len(st.Logs))
 					for _, v := range st.Logs {
+						v := *v
 						v.Timestamp = v.Timestamp.Add(-*w.diff)
+						logs = append(logs, &v)
+					}
+
+					st = &client.SolveStatus{
+						Vertexes: vertexes,
+						Statuses: statuses,
+						Logs:     logs,
+						Warnings: st.Warnings,
 					}
 				}
 				in.Status() <- st