Skip to content

Commit ad9a37a

Browse files
committed
move Secretenv from Meta to InitMessage
Signed-off-by: Alex Suraci <[email protected]>
1 parent ce088e1 commit ad9a37a

File tree

7 files changed

+401
-399
lines changed

7 files changed

+401
-399
lines changed

frontend/gateway/gateway.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1300,7 +1300,7 @@ func (lbf *llbBridgeForwarder) ExecProcess(srv pb.LLBBridge_ExecProcessServer) e
13001300
proc, err := ctr.Start(initCtx, gwclient.StartRequest{
13011301
Args: init.Meta.Args,
13021302
Env: init.Meta.Env,
1303-
SecretEnv: init.Meta.Secretenv,
1303+
SecretEnv: init.Secretenv,
13041304
User: init.Meta.User,
13051305
Cwd: init.Meta.Cwd,
13061306
Tty: init.Tty,

frontend/gateway/grpcclient/client.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -824,14 +824,14 @@ func (ctr *container) Start(ctx context.Context, req client.StartRequest) (clien
824824
init := &pb.InitMessage{
825825
ContainerID: ctr.id,
826826
Meta: &opspb.Meta{
827-
Args: req.Args,
828-
Env: req.Env,
829-
Cwd: req.Cwd,
830-
User: req.User,
831-
Secretenv: req.SecretEnv,
827+
Args: req.Args,
828+
Env: req.Env,
829+
Cwd: req.Cwd,
830+
User: req.User,
832831
},
833-
Tty: req.Tty,
834-
Security: req.SecurityMode,
832+
Tty: req.Tty,
833+
Security: req.SecurityMode,
834+
Secretenv: req.SecretEnv,
835835
}
836836
init.Meta.RemoveMountStubsRecursive = req.RemoveMountStubsRecursive
837837
if req.Stdin != nil {

frontend/gateway/pb/gateway.pb.go

Lines changed: 219 additions & 155 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

frontend/gateway/pb/gateway.proto

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ service LLBBridge {
3838
rpc ExecProcess(stream ExecMessage) returns (stream ExecMessage);
3939

4040
// apicaps:CapGatewayWarnings
41-
rpc Warn(WarnRequest) returns (WarnResponse);
41+
rpc Warn(WarnRequest) returns (WarnResponse);
4242
}
4343

4444
message Result {
@@ -138,7 +138,7 @@ message SolveRequest {
138138
// 4 was removed in BuildKit v0.11.0.
139139
bool allowResultReturn = 5;
140140
bool allowResultArrayRef = 6;
141-
141+
142142
// apicaps.CapSolveInlineReturn deprecated
143143
bool Final = 10;
144144
bytes ExporterAttr = 11;
@@ -165,7 +165,7 @@ message SolveResponse {
165165
string ref = 1; // can be used by readfile request
166166
// deprecated
167167
/* bytes ExporterAttr = 2;*/
168-
168+
169169
// these fields are returned when allowMapReturn was set
170170
Result result = 3;
171171
}
@@ -256,7 +256,7 @@ message ExecMessage {
256256
// InitMessage sent from client to server will start a new process in a
257257
// container
258258
InitMessage Init = 2;
259-
// FdMessage used from client to server for input (stdin) and
259+
// FdMessage used from client to server for input (stdin) and
260260
// from server to client for output (stdout, stderr)
261261
FdMessage File = 3;
262262
// ResizeMessage used from client to server for terminal resize events
@@ -281,6 +281,7 @@ message InitMessage{
281281
repeated uint32 Fds = 3;
282282
bool Tty = 4;
283283
pb.SecurityMode Security = 5;
284+
repeated pb.SecretEnv secretenv = 6;
284285
}
285286

286287
message ExitMessage {

solver/pb/ops.pb.go

Lines changed: 168 additions & 230 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

solver/pb/ops.proto

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,6 @@ message Meta {
6464
repeated Ulimit ulimit = 9;
6565
string cgroupParent = 10;
6666
bool removeMountStubsRecursive = 11;
67-
repeated SecretEnv secretenv = 12;
6867
}
6968

7069
message HostIP {

util/stack/stack.pb.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)