Skip to content

Commit c120cdf

Browse files
committed
testutil: set cdi spec dir with config
Signed-off-by: CrazyMax <[email protected]>
1 parent dc76379 commit c120cdf

File tree

3 files changed

+19
-3
lines changed

3 files changed

+19
-3
lines changed

util/testutil/workers/containerd.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,6 @@ disabled_plugins = ["io.containerd.grpc.v1.cri"]
212212
"--containerd-worker=true",
213213
"--containerd-worker-addr", address,
214214
"--containerd-worker-labels=org.mobyproject.buildkit.worker.sandbox=true", // Include use of --containerd-worker-labels to trigger https://github.com/moby/buildkit/pull/603
215-
"--cdi-spec-dir=" + cfg.CDISpecDir,
216215
}
217216
buildkitdArgs = applyBuildkitdPlatformFlags(buildkitdArgs)
218217
buildkitdArgs = append(buildkitdArgs, snBuildkitdArgs...)

util/testutil/workers/oci.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@ func (s *OCI) New(ctx context.Context, cfg *integration.BackendConfig) (integrat
5252
"--containerd-worker=false",
5353
"--oci-worker-gc=false",
5454
"--oci-worker-labels=org.mobyproject.buildkit.worker.sandbox=true",
55-
"--cdi-spec-dir=" + cfg.CDISpecDir,
5655
}
5756

5857
if s.Snapshotter != "" {

util/testutil/workers/util.go

Lines changed: 19 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,20 @@ func (osp otelSocketPath) UpdateConfigFile(in string) string {
2525
`, in, osp)
2626
}
2727

28+
func withCDISpecDir(specDir string) integration.ConfigUpdater {
29+
return cdiSpecDir(specDir)
30+
}
31+
32+
type cdiSpecDir string
33+
34+
func (csd cdiSpecDir) UpdateConfigFile(in string) string {
35+
return fmt.Sprintf(`%s
36+
37+
[cdi]
38+
specDirs = [%q]
39+
`, in, csd)
40+
}
41+
2842
func runBuildkitd(
2943
conf *integration.BackendConfig,
3044
args []string,
@@ -61,7 +75,11 @@ func runBuildkitd(
6175
deferF.Append(func() error { return os.RemoveAll(tmpdir) })
6276

6377
cfgfile, err := integration.WriteConfig(
64-
append(conf.DaemonConfig, withOTELSocketPath(getTraceSocketPath(tmpdir))))
78+
append(conf.DaemonConfig,
79+
withOTELSocketPath(getTraceSocketPath(tmpdir)),
80+
withCDISpecDir(conf.CDISpecDir),
81+
),
82+
)
6583
if err != nil {
6684
return "", "", nil, err
6785
}

0 commit comments

Comments
 (0)