Skip to content

Commit c57c4ae

Browse files
committed
tests: refactor integration test package
This patch splits up the integration test package down into several parts, the core integration helpers, the buildkit test workers and various test helpers. With this, we can split the worker features off as well, which improves the general reusability of the package, so we can create our own custom features in buildx where we reuse this package. Signed-off-by: Justin Chadwell <[email protected]>
1 parent d0f47df commit c57c4ae

28 files changed

+599
-572
lines changed

client/build_test.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ import (
2626
utilsystem "github.com/moby/buildkit/util/system"
2727
"github.com/moby/buildkit/util/testutil/echoserver"
2828
"github.com/moby/buildkit/util/testutil/integration"
29+
"github.com/moby/buildkit/util/testutil/workers"
2930
digest "github.com/opencontainers/go-digest"
3031
"github.com/pkg/errors"
3132
"github.com/stretchr/testify/require"
@@ -1839,7 +1840,7 @@ func testClientGatewayExecFileActionError(t *testing.T, sb integration.Sandbox)
18391840
// testClientGatewayContainerSecurityMode ensures that the correct security mode
18401841
// is propagated to the gateway container
18411842
func testClientGatewayContainerSecurityMode(t *testing.T, sb integration.Sandbox) {
1842-
integration.CheckFeatureCompat(t, sb, integration.FeatureSecurityMode)
1843+
workers.CheckFeatureCompat(t, sb, workers.FeatureSecurityMode)
18431844
requiresLinux(t)
18441845

18451846
ctx := sb.Context()
@@ -2215,7 +2216,7 @@ func testClientGatewayContainerSignal(t *testing.T, sb integration.Sandbox) {
22152216
}
22162217

22172218
func testClientGatewayNilResult(t *testing.T, sb integration.Sandbox) {
2218-
integration.CheckFeatureCompat(t, sb, integration.FeatureMergeDiff)
2219+
workers.CheckFeatureCompat(t, sb, workers.FeatureMergeDiff)
22192220
requiresLinux(t)
22202221
c, err := New(sb.Context(), sb.Address())
22212222
require.NoError(t, err)
@@ -2250,7 +2251,7 @@ func testClientGatewayNilResult(t *testing.T, sb integration.Sandbox) {
22502251
}
22512252

22522253
func testClientGatewayEmptyImageExec(t *testing.T, sb integration.Sandbox) {
2253-
integration.CheckFeatureCompat(t, sb, integration.FeatureDirectPush)
2254+
workers.CheckFeatureCompat(t, sb, workers.FeatureDirectPush)
22542255
c, err := New(sb.Context(), sb.Address())
22552256
require.NoError(t, err)
22562257
defer c.Close()

client/client_nydus_test.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ import (
1515
"github.com/moby/buildkit/identity"
1616
"github.com/moby/buildkit/util/compression"
1717
"github.com/moby/buildkit/util/testutil/integration"
18+
"github.com/moby/buildkit/util/testutil/workers"
1819
ocispecs "github.com/opencontainers/image-spec/specs-go/v1"
1920
"github.com/pkg/errors"
2021
"github.com/stretchr/testify/require"
@@ -28,7 +29,7 @@ func TestNydusIntegration(t *testing.T) {
2829
}
2930

3031
func testBuildExportNydusWithHybrid(t *testing.T, sb integration.Sandbox) {
31-
integration.CheckFeatureCompat(t, sb, integration.FeatureDirectPush)
32+
workers.CheckFeatureCompat(t, sb, workers.FeatureDirectPush)
3233
requiresLinux(t)
3334

3435
cdAddress := sb.ContainerdAddress()

0 commit comments

Comments
 (0)