errdefs: mark ENOMEM & ENOSPC with ResourceExhausted code

Signed-off-by: Tonis Tiigi <[email protected]>

Author: tonistiigi

errdefs/internal.go

@@ -36,14 +36,24 @@ func IsInternal(err error) bool {
 
 	var errno syscall.Errno
 	if errors.As(err, &errno) {
-		if isInternalSyscall(errno) {
+		if _, ok := isInternalSyscall(errno); ok {
 			return true
 		}
 	}
 	return false
 }
 
-func isInternalSyscall(err syscall.Errno) bool {
-	_, ok := syscallErrors()[err]
-	return ok
+func IsResourceExhausted(err error) bool {
+	var errno syscall.Errno
+	if errors.As(err, &errno) {
+		if v, ok := isInternalSyscall(errno); ok && v {
+			return v
+		}
+	}
+	return false
+}
+
+func isInternalSyscall(err syscall.Errno) (bool, bool) {
+	v, ok := syscallErrors()[err]
+	return v, ok
 }

errdefs/internal_linux.go

@@ -9,13 +9,15 @@ import (
 	"golang.org/x/sys/unix"
 )
 
-func syscallErrors() map[syscall.Errno]struct{} {
-	return map[syscall.Errno]struct{}{
-		unix.EIO:             {}, // I/O error
-		unix.ENOMEM:          {}, // Out of memory
-		unix.EFAULT:          {}, // Bad address
-		unix.ENOSPC:          {}, // No space left on device
-		unix.ENOTRECOVERABLE: {}, // State not recoverable
-		unix.EHWPOISON:       {}, // Memory page has hardware error
+// syscallErrors returns a map of syscall errors that are considered internal.
+// value is true if the error is of type resource exhaustion, false otherwise.
+func syscallErrors() map[syscall.Errno]bool {
+	return map[syscall.Errno]bool{
+		unix.EIO:             false, // I/O error
+		unix.ENOMEM:          true,  // Out of memory
+		unix.EFAULT:          false, // Bad address
+		unix.ENOSPC:          true,  // No space left on device
+		unix.ENOTRECOVERABLE: false, // State not recoverable
+		unix.EHWPOISON:       false, // Memory page has hardware error
 	}
 }

errdefs/internal_nolinux.go

@@ -5,6 +5,6 @@ package errdefs
 
 import "syscall"
 
-func syscallErrors() map[syscall.Errno]struct{} {
+func syscallErrors() map[syscall.Errno]bool {
 	return nil
 }

util/grpcerrors/grpcerrors.go

@@ -96,6 +96,9 @@ func withDetails(ctx context.Context, s *status.Status, details ...proto.Message
 
 func Code(err error) codes.Code {
 	if errdefs.IsInternal(err) {
+		if errdefs.IsResourceExhausted(err) {
+			return codes.ResourceExhausted
+		}
 		return codes.Internal
 	}