cdi: test find devices

Signed-off-by: CrazyMax <[email protected]>

Author: crazy-max

solver/llbsolver/cdidevices/fixtures/vendor1-device.yaml

@@ -0,0 +1,9 @@
+cdiVersion: "0.6.0"
+kind: "vendor1.com/device"
+devices:
+  - name: foo
+    containerEdits:
+      env:
+        - FOO=injected
+annotations:
+  org.mobyproject.buildkit.device.autoallow: true

solver/llbsolver/cdidevices/fixtures/vendor1-deviceclass.yaml

@@ -0,0 +1,28 @@
+cdiVersion: "0.6.0"
+kind: "vendor1.com/deviceclass"
+annotations:
+  foo.bar.baz: FOO
+  org.mobyproject.buildkit.device.autoallow: true
+devices:
+  - name: foo
+    annotations:
+      org.mobyproject.buildkit.device.class: class1
+    containerEdits:
+      env:
+        - FOO=injected
+  - name: bar
+    annotations:
+      org.mobyproject.buildkit.device.class: class1
+    containerEdits:
+      env:
+        - BAR=injected
+  - name: baz
+    annotations:
+      org.mobyproject.buildkit.device.class: class2
+    containerEdits:
+      env:
+        - BAZ=injected
+  - name: qux
+    containerEdits:
+      env:
+        - QUX=injected

solver/llbsolver/cdidevices/fixtures/vendor1-devicemulti.yaml

@@ -0,0 +1,21 @@
+cdiVersion: "0.6.0"
+kind: "vendor1.com/devicemulti"
+devices:
+  - name: foo
+    containerEdits:
+      env:
+        - FOO=injected
+  - name: bar
+    containerEdits:
+      env:
+        - BAR=injected
+  - name: baz
+    containerEdits:
+      env:
+        - BAZ=injected
+  - name: qux
+    containerEdits:
+      env:
+        - QUX=injected
+annotations:
+  org.mobyproject.buildkit.device.autoallow: true

solver/llbsolver/cdidevices/manager.go

@@ -15,8 +15,8 @@ import (
 )
 
 const (
-	deviceAnnotationClass = "org.mobyproject.buildkit.device.class"
-	deviceAutoAllow       = "org.mobyproject.buildkit.device.autoallow"
+	deviceAnnotationClass     = "org.mobyproject.buildkit.device.class"
+	deviceAnnotationAutoAllow = "org.mobyproject.buildkit.device.autoallow"
 )
 
 var installers = map[string]Setup{}
@@ -63,7 +63,7 @@ func (m *Manager) isAutoAllowed(kind, name string, annotations map[string]string
 	if _, ok := m.autoAllowed[kind]; ok {
 		return true
 	}
-	if v, ok := annotations[deviceAutoAllow]; ok {
+	if v, ok := annotations[deviceAnnotationAutoAllow]; ok {
 		if b, err := strconv.ParseBool(v); err == nil && b {
 			return true
 		}

solver/llbsolver/cdidevices/manager_test.go

@@ -0,0 +1,70 @@
+package cdidevices
+
+import (
+	"testing"
+
+	"github.com/moby/buildkit/solver/pb"
+	"github.com/stretchr/testify/require"
+	"tags.cncf.io/container-device-interface/pkg/cdi"
+)
+
+func TestFindDevices(t *testing.T) {
+	tests := []struct {
+		name     string
+		devices  []*pb.CDIDevice
+		expected []string
+		err      bool
+	}{
+		{
+			name: "Find specific device",
+			devices: []*pb.CDIDevice{
+				{Name: "vendor1.com/device=foo"},
+			},
+			expected: []string{"vendor1.com/device=foo"},
+		},
+		{
+			name: "Find first devices",
+			devices: []*pb.CDIDevice{
+				{Name: "vendor1.com/devicemulti"},
+			},
+			expected: []string{"vendor1.com/devicemulti=bar"},
+		},
+		{
+			name: "Find all devices of a kind",
+			devices: []*pb.CDIDevice{
+				{Name: "vendor1.com/devicemulti=*"},
+			},
+			expected: []string{"vendor1.com/devicemulti=foo", "vendor1.com/devicemulti=bar", "vendor1.com/devicemulti=baz", "vendor1.com/devicemulti=qux"},
+		},
+		{
+			name: "Find devices by class",
+			devices: []*pb.CDIDevice{
+				{Name: "vendor1.com/deviceclass=class1"},
+			},
+			expected: []string{"vendor1.com/deviceclass=foo", "vendor1.com/deviceclass=bar"},
+		},
+		{
+			name: "Device not found",
+			devices: []*pb.CDIDevice{
+				{Name: "vendor1.com/device=unknown"},
+			},
+			expected: nil,
+			err:      true,
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			cache, err := cdi.NewCache(cdi.WithSpecDirs("./fixtures"))
+			require.NoError(t, err)
+			manager := NewManager(cache, nil)
+			result, err := manager.FindDevices(tt.devices...)
+			if tt.err {
+				require.Error(t, err)
+			} else {
+				require.NoError(t, err)
+				require.ElementsMatch(t, tt.expected, result)
+			}
+		})
+	}
+}