Skip to content

Commit fa867bc

Browse files
authored
Merge pull request moby#5064 from dvdksn/docs-add-checksum-https
dockerfile: clarify that checksum works with HTTPS
2 parents 2ec1338 + 1730844 commit fa867bc

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

frontend/dockerfile/dockerfile2llb/convert.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1354,7 +1354,7 @@ func dispatchCopy(d *dispatchState, cfg copyConfig) error {
13541354
return errors.New("checksum can't be specified for multiple sources")
13551355
}
13561356
if !isHTTPSource(cfg.params.SourcePaths[0]) {
1357-
return errors.New("checksum can't be specified for non-HTTP sources")
1357+
return errors.New("checksum can't be specified for non-HTTP(S) sources")
13581358
}
13591359
}
13601360

frontend/dockerfile/dockerfile_addchecksum_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,6 +162,6 @@ ADD --checksum=%s foo /tmp/foo
162162
dockerui.DefaultLocalNameContext: dir,
163163
},
164164
}, nil)
165-
require.Error(t, err, "checksum can't be specified for non-HTTP sources")
165+
require.Error(t, err, "checksum can't be specified for non-HTTP(S) sources")
166166
})
167167
}

frontend/dockerfile/docs/reference.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1339,7 +1339,7 @@ The `--checksum` flag lets you verify the checksum of a remote resource:
13391339
ADD --checksum=sha256:24454f830cdb571e2c4ad15481119c43b3cafd48dd869a9b2945d1036d1dc68d https://mirrors.edge.kernel.org/pub/linux/kernel/Historic/linux-0.01.tar.gz /
13401340
```
13411341

1342-
The `--checksum` flag only supports HTTP sources currently.
1342+
The `--checksum` flag only supports HTTP(S) sources.
13431343

13441344
### ADD --chown --chmod
13451345

0 commit comments

Comments
 (0)