Merge pull request moby#3687 from cryeo/remove-kubepod-context-validation

remove context name validation from kubepod connhelper

Author: tonistiigi

client/connhelper/kubepod/kubepod.go

@@ -51,9 +51,6 @@ func SpecFromURL(u *url.URL) (*Spec, error) {
 		Pod:       u.Hostname(),
 		Container: q.Get("container"),
 	}
-	if sp.Context != "" && !validKubeIdentifier(sp.Context) {
-		return nil, errors.Errorf("unsupported context name: %q", sp.Context)
-	}
 	if sp.Namespace != "" && !validKubeIdentifier(sp.Namespace) {
 		return nil, errors.Errorf("unsupported namespace name: %q", sp.Namespace)
 	}

client/connhelper/kubepod/kubepod_test.go

@@ -15,8 +15,13 @@ func TestSpecFromURL(t *testing.T) {
 		"kube-pod://podname?container=containername&namespace=nsname&context=ctxname": {
 			Context: "ctxname", Namespace: "nsname", Pod: "podname", Container: "containername",
 		},
+		"kube-pod://podname?container=containername&namespace=nsname&context=user@cluster": {
+			Context: "user@cluster", Namespace: "nsname", Pod: "podname", Container: "containername",
+		},
 		"kube-pod://":                     nil,
 		"kube-pod://unsupported_pod_name": nil,
+		"kube-pod://podname?container=unsupported_container_name&namespace=nsname&context=ctxname": nil,
+		"kube-pod://podname?container=containername&namespace=unsupported_ns_name&context=ctxname": nil,
 	}
 	for s, expected := range cases {
 		u, err := url.Parse(s)