@@ -22,12 +22,12 @@ start participating.
22
22
The Docker maintainers take security seriously. If you discover a security
23
23
issue, please bring it to their attention right away!
24
24
25
- Please ** DO NOT** file a public issue, instead send your report privately to
25
+ Please ** DO NOT** file a public issue, instead, send your report privately to
26
26
27
27
28
- Security reports are greatly appreciated and we will publicly thank you for it .
28
+ Security reports are greatly appreciated and we will publicly thank you for them .
29
29
We also like to send gifts&mdash ; if you're into Docker swag, make sure to let
30
- us know. We currently do not offer a paid security bounty program, but are not
30
+ us know. We currently do not offer a paid security bounty program but are not
31
31
ruling it out in the future.
32
32
33
33
@@ -39,19 +39,19 @@ and will thank you for it!
39
39
40
40
Check that [ our issue database] ( https://github.com/docker/compose/labels/Docker%20Compose%20V2 )
41
41
doesn't already include that problem or suggestion before submitting an issue.
42
- If you find a match, you can use the "subscribe" button to get notified on
42
+ If you find a match, you can use the "subscribe" button to get notified of
43
43
updates. Do * not* leave random "+1" or "I have this too" comments, as they
44
44
only clutter the discussion, and don't help to resolve it. However, if you
45
45
have ways to reproduce the issue or have additional information that may help
46
- resolving the issue, please leave a comment.
46
+ resolve the issue, please leave a comment.
47
47
48
48
When reporting issues, always include:
49
49
50
50
* The output of ` docker version ` .
51
51
* The output of ` docker context show ` .
52
52
* The output of ` docker info ` .
53
53
54
- Also include the steps required to reproduce the problem if possible and
54
+ Also, include the steps required to reproduce the problem if possible and
55
55
applicable. This information will help us review and fix your issue faster.
56
56
When sending lengthy log files, consider posting them as a gist
57
57
(https://gist.github.com ).
@@ -124,7 +124,7 @@ Fork the repository and make changes on your fork in a feature branch:
124
124
issue.
125
125
126
126
Submit unit tests for your changes. Go has a great test framework built in; use
127
- it! Take a look at existing tests for inspiration. Also end-to-end tests are
127
+ it! Take a look at existing tests for inspiration. Also, end-to-end tests are
128
128
available. Run the full test suite, both unit tests and e2e tests on your
129
129
branch before submitting a pull request. See [ BUILDING.md] ( BUILDING.md ) for
130
130
instructions to build and run tests.
@@ -145,7 +145,7 @@ suggested modifications and push additional commits to your feature branch. Post
145
145
a comment after pushing. New commits show up in the pull request automatically,
146
146
but the reviewers are notified only when you comment.
147
147
148
- Pull requests must be cleanly rebased on top of master without multiple branches
148
+ Pull requests must be cleanly rebased on top of the base branch without multiple branches
149
149
mixed into the PR.
150
150
151
151
** Git tip** : If your PR no longer merges cleanly, use ` rebase master ` in your
@@ -165,7 +165,7 @@ changes in the same pull request so that a revert would remove all traces of
165
165
the feature or fix.
166
166
167
167
Include an issue reference like ` Closes #XXXX ` or ` Fixes #XXXX ` in the pull
168
- request description that close an issue. Including references automatically
168
+ request description that closes an issue. Including references automatically
169
169
closes the issue on a merge.
170
170
171
171
Please do not add yourself to the ` AUTHORS ` file, as it is regenerated regularly
@@ -256,7 +256,7 @@ your help to keep it that way. To help with this we've come up with some general
256
256
guidelines for the community as a whole:
257
257
258
258
* Be nice: Be courteous, respectful and polite to fellow community members:
259
- no regional, racial, gender, or other abuse will be tolerated. We like
259
+ no regional, racial, gender or other abuse will be tolerated. We like
260
260
nice people way better than mean ones!
261
261
262
262
* Encourage diversity and participation: Make everyone in our community feel
@@ -270,10 +270,10 @@ guidelines for the community as a whole:
270
270
271
271
* Stay on topic: Make sure that you are posting to the correct channel and
272
272
avoid off-topic discussions. Remember when you update an issue or respond
273
- to an email you are potentially sending to a large number of people. Please
274
- consider this before you update. Also remember that nobody likes spam.
273
+ to an email you are potentially sending it to a large number of people. Please
274
+ consider this before you update. Also, remember that nobody likes spam.
275
275
276
- * Don't send email to the maintainers: There's no need to send email to the
276
+ * Don't send emails to the maintainers: There's no need to send emails to the
277
277
maintainers to ask them to investigate an issue or to take a look at a
278
278
pull request. Instead of sending an email, GitHub mentions should be
279
279
used to ping maintainers to review a pull request, a proposal or an
@@ -287,7 +287,7 @@ to result in a solid, consistent codebase.
287
287
288
288
It is possible that the code base does not currently comply with these
289
289
guidelines. We are not looking for a massive PR that fixes this, since that
290
- goes against the spirit of the guidelines. All new contributions should make a
290
+ goes against the spirit of the guidelines. All new contributors should make their
291
291
best effort to clean up and make the code base better than they left it.
292
292
Obviously, apply your best judgement. Remember, the goal here is to make the
293
293
code base easier for humans to navigate and understand. Always keep that in
@@ -301,7 +301,7 @@ The rules:
301
301
3 . All code should follow the guidelines covered in [ Effective
302
302
Go] ( http://golang.org/doc/effective_go.html ) and [ Go Code Review
303
303
Comments] ( https://github.com/golang/go/wiki/CodeReviewComments ) .
304
- 4 . Comment the code. Tell us the why, the history and the context.
304
+ 4 . Include code comments . Tell us the why, the history and the context.
305
305
5 . Document _ all_ declarations and methods, even private ones. Declare
306
306
expectations, caveats and anything else that may be important. If a type
307
307
gets exported, having the comments already there will ensure it's ready.
0 commit comments