trace: do not block connecting to OTLP endpoint (docker#10882)

milas · web-flow · commit 0be8e4a676d5 · 2023-08-08T15:47:18.000-04:00
This was left over from debugging, but we should not block.
OTel will handle the connection in the background.

Signed-off-by: Milas Bowman &lt;milas.bowman@docker.com&gt;
diff --git a/internal/tracing/docker_context.go b/internal/tracing/docker_context.go
@@ -69,7 +69,6 @@ func traceClientFromDockerContext(dockerCli command.Cli, otelEnv envMap) (otlptr
 		cfg.Endpoint,
 		grpc.WithContextDialer(DialInMemory),
 		grpc.WithTransportCredentials(insecure.NewCredentials()),
-		grpc.WithBlock(),
 	)
 	if err != nil {
 		return nil, fmt.Errorf("initializing otel connection from docker context metadata: %v", err)

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,6 @@ func traceClientFromDockerContext(dockerCli command.Cli, otelEnv envMap) (otlptr`
`69`	`69`	`cfg.Endpoint,`
`70`	`70`	`grpc.WithContextDialer(DialInMemory),`
`71`	`71`	`grpc.WithTransportCredentials(insecure.NewCredentials()),`
`72`		`- grpc.WithBlock(),`
`73`	`72`	`)`
`74`	`73`	`if err != nil {`
`75`	`74`	`return nil, fmt.Errorf("initializing otel connection from docker context metadata: %v", err)`