Propagate GroupAdd from ServiceConfig to HostConfig

lancechentw · ndeloof · commit 1191023fb624 · 2021-12-17T15:08:14.000+01:00
The `group_add` key is parsed correctly from a compose file, but it is not
passed into the `ContainerCreate` API call, thus the configuration does
not take effect. This commit fixes the issue by propagating the
configuration from Docker compose's ServiceConfig to Docker container's
HostConfig.

Signed-off-by: Lance Chen &lt;hello@lancechen.tw&gt;
diff --git a/pkg/compose/create.go b/pkg/compose/create.go
@@ -380,6 +380,7 @@ func (s *composeService) getCreateOptions(ctx context.Context, p *types.Project,
 		Isolation:      container.Isolation(service.Isolation),
 		Runtime:        service.Runtime,
 		LogConfig:      logConfig,
+		GroupAdd:       service.GroupAdd,
 	}
 
 	return &containerConfig, &hostConfig, networkConfig, nil

Original file line number	Diff line number	Diff line change
`@@ -380,6 +380,7 @@ func (s composeService) getCreateOptions(ctx context.Context, p types.Project,`
`380`	`380`	`Isolation: container.Isolation(service.Isolation),`
`381`	`381`	`Runtime: service.Runtime,`
`382`	`382`	`LogConfig: logConfig,`
	`383`	`+ GroupAdd: service.GroupAdd,`
`383`	`384`	`}`
`384`	`385`
`385`	`386`	`return &containerConfig, &hostConfig, networkConfig, nil`