Skip to content

Commit 139edc4

Browse files
maiamccndeloof
authored andcommitted
cleanup: wrap errors properly (docker#772)
* cleanup: wrap errors properly * fix build error * asdfg linux * fix test
1 parent 38b3f3b commit 139edc4

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

pkg/watch/watcher_linux.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
package watch
22

33
import (
4-
"fmt"
54
"io/ioutil"
65
"log"
76
"os"
87
"path/filepath"
98
"strconv"
109
"strings"
1110

11+
"github.com/pkg/errors"
1212
"github.com/windmilleng/fsnotify"
1313
"google.golang.org/grpc"
1414
"google.golang.org/grpc/codes"
@@ -29,27 +29,27 @@ type linuxNotify struct {
2929
func (d *linuxNotify) Add(name string) error {
3030
fi, err := os.Stat(name)
3131
if err != nil && !os.IsNotExist(err) {
32-
return fmt.Errorf("notify.Add(%q): %v", name, err)
32+
return errors.Wrapf(err, "notify.Add(%q)", name)
3333
}
3434

35-
// if it's a file that doesn't exist watch it's parent
35+
// if it's a file that doesn't exist, watch its parent
3636
if os.IsNotExist(err) {
3737
parent := filepath.Join(name, "..")
3838
err = d.watcher.Add(parent)
3939
if err != nil {
40-
return fmt.Errorf("notify.Add(%q): %v", name, err)
40+
return errors.Wrapf(err, "notify.Add(%q)", name)
4141
}
4242
d.watchList[parent] = true
4343
} else if fi.IsDir() {
4444
err = d.watchRecursively(name)
4545
if err != nil {
46-
return fmt.Errorf("notify.Add(%q): %v", name, err)
46+
return errors.Wrapf(err, "notify.Add(%q)", name)
4747
}
4848
d.watchList[name] = true
4949
} else {
5050
err = d.watcher.Add(name)
5151
if err != nil {
52-
return fmt.Errorf("notify.Add(%q): %v", name, err)
52+
return errors.Wrapf(err, "notify.Add(%q)", name)
5353
}
5454
d.watchList[name] = true
5555
}
@@ -68,7 +68,7 @@ func (d *linuxNotify) watchRecursively(dir string) error {
6868
if os.IsNotExist(err) {
6969
return nil
7070
}
71-
return fmt.Errorf("watcher.Add(%q): %v", path, err)
71+
return errors.Wrapf(err, "watcher.Add(%q)", path)
7272
}
7373
return nil
7474
})

0 commit comments

Comments
 (0)