Merge pull request docker#10784 from shantanoo-desai/v2

glours · web-flow · commit 29daae3d6ecf · 2023-07-10T14:54:16.000+02:00
fix(secrets): file permission value does not comply with spec
diff --git a/pkg/compose/secrets.go b/pkg/compose/secrets.go
@@ -58,7 +58,7 @@ func createTar(env string, config types.ServiceSecretConfig) (bytes.Buffer, erro
 	value := []byte(env)
 	b := bytes.Buffer{}
 	tarWriter := tar.NewWriter(&b)
-	mode := uint32(0o400)
+	mode := uint32(0o444)
 	if config.Mode != nil {
 		mode = *config.Mode
 	}

Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ func createTar(env string, config types.ServiceSecretConfig) (bytes.Buffer, erro`
`58`	`58`	`value := []byte(env)`
`59`	`59`	`b := bytes.Buffer{}`
`60`	`60`	`tarWriter := tar.NewWriter(&b)`
`61`		`- mode := uint32(0o400)`
	`61`	`+ mode := uint32(0o444)`
`62`	`62`	`if config.Mode != nil {`
`63`	`63`	`mode = *config.Mode`
`64`	`64`	`}`