Merge pull request docker#11180 from ulyssessouza/skip-flaky-tests

glours · web-flow · commit 43c3f5459867 · 2023-11-10T19:51:00.000+01:00
skips flaky e2e tests on watch and attach
diff --git a/pkg/e2e/compose_test.go b/pkg/e2e/compose_test.go
@@ -141,6 +141,8 @@ func TestDownComposefileInParentFolder(t *testing.T) {
 }
 
 func TestAttachRestart(t *testing.T) {
+	t.Skip("Skipping test until we can fix it")
+
 	if _, ok := os.LookupEnv("CI"); ok {
 		t.Skip("Skipping test on CI... flaky")
 	}
diff --git a/pkg/e2e/watch_test.go b/pkg/e2e/watch_test.go
@@ -35,6 +35,8 @@ import (
 )
 
 func TestWatch(t *testing.T) {
+	t.Skip("Skipping watch tests until we can figure out why they are flaky/failing")
+
 	services := []string{"alpine", "busybox", "debian"}
 	t.Run("docker cp", func(t *testing.T) {
 		for _, svcName := range services {

Original file line number	Diff line number	Diff line change
`@@ -141,6 +141,8 @@ func TestDownComposefileInParentFolder(t *testing.T) {`
`141`	`141`	`}`
`142`	`142`
`143`	`143`	`func TestAttachRestart(t *testing.T) {`
	`144`	`+ t.Skip("Skipping test until we can fix it")`
	`145`	`+`
`144`	`146`	`if _, ok := os.LookupEnv("CI"); ok {`
`145`	`147`	`t.Skip("Skipping test on CI... flaky")`
`146`	`148`	`}`
Original file line number	Diff line number	Diff line change
`@@ -35,6 +35,8 @@ import (`
`35`	`35`	`)`
`36`	`36`
`37`	`37`	`func TestWatch(t *testing.T) {`
	`38`	`+ t.Skip("Skipping watch tests until we can figure out why they are flaky/failing")`
	`39`	`+`
`38`	`40`	`services := []string{"alpine", "busybox", "debian"}`
`39`	`41`	`t.Run("docker cp", func(t *testing.T) {`
`40`	`42`	`for _, svcName := range services {`