Skip to content

Commit b032999

Browse files
committed
read COMPOSE_REMOVE_ORPHANS from .env
Signed-off-by: Nicolas De Loof <[email protected]>
1 parent 5059a1d commit b032999

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

cmd/compose/up.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,9 @@ func upCommand(p *ProjectOptions, dockerCli command.Cli, backend api.Service, ex
112112
create.pullChanged = cmd.Flags().Changed("pull")
113113
create.timeChanged = cmd.Flags().Changed("timeout")
114114
up.navigationMenuChanged = cmd.Flags().Changed("menu")
115+
if !cmd.Flags().Changed("remove-orphans") {
116+
create.removeOrphans = utils.StringToBool(os.Getenv(ComposeRemoveOrphans))
117+
}
115118
return validateFlags(&up, &create)
116119
}),
117120
RunE: p.WithServices(dockerCli, func(ctx context.Context, project *types.Project, services []string) error {
@@ -138,8 +141,7 @@ func upCommand(p *ProjectOptions, dockerCli command.Cli, backend api.Service, ex
138141
flags.BoolVar(&create.Build, "build", false, "Build images before starting containers")
139142
flags.BoolVar(&create.noBuild, "no-build", false, "Don't build an image, even if it's policy")
140143
flags.StringVar(&create.Pull, "pull", "policy", `Pull image before running ("always"|"missing"|"never")`)
141-
removeOrphans := utils.StringToBool(os.Getenv(ComposeRemoveOrphans))
142-
flags.BoolVar(&create.removeOrphans, "remove-orphans", removeOrphans, "Remove containers for services not defined in the Compose file")
144+
flags.BoolVar(&create.removeOrphans, "remove-orphans", false, "Remove containers for services not defined in the Compose file")
143145
flags.StringArrayVar(&create.scale, "scale", []string{}, "Scale SERVICE to NUM instances. Overrides the `scale` setting in the Compose file if present.")
144146
flags.BoolVar(&up.noColor, "no-color", false, "Produce monochrome output")
145147
flags.BoolVar(&up.noPrefix, "no-log-prefix", false, "Don't print prefix in logs")

0 commit comments

Comments
 (0)