Skip to content

Commit bac398a

Browse files
committed
Fix .env and --envfile priorities
Signed-off-by: Ulysses Souza <[email protected]>
1 parent def189f commit bac398a

File tree

2 files changed

+20
-0
lines changed

2 files changed

+20
-0
lines changed

pkg/e2e/compose_environment_test.go

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,19 @@ func TestEnvPriority(t *testing.T) {
7878
assert.Equal(t, strings.TrimSpace(res.Stdout()), "shell-run")
7979
})
8080

81+
// No Compose file & no env variable but override env file
82+
// 1. Compose file
83+
// 2. Shell environment variables
84+
// 3. Environment file <-- Result expected
85+
// 4. Dockerfile
86+
// 5. Variable is not defined
87+
t.Run("override env file from compose", func(t *testing.T) {
88+
res := c.RunDockerComposeCmd("-f", "./fixtures/environment/env-priority/compose-with-env-file.yaml",
89+
"--project-directory", projectDir,
90+
"run", "--rm", "-e", "WHEREAMI", "env-compose-priority")
91+
assert.Equal(t, strings.TrimSpace(res.Stdout()), "override")
92+
})
93+
8194
// No Compose file & no env variable but override env file
8295
// 1. Compose file
8396
// 2. Shell environment variables
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
services:
2+
env-compose-priority:
3+
image: env-compose-priority
4+
build:
5+
context: .
6+
env_file:
7+
- .env.override

0 commit comments

Comments
 (0)