Skip to content

Commit dbe7de5

Browse files
committed
don't try to start dependencies when there are none
Signed-off-by: Nicolas De Loof <[email protected]>
1 parent fcff396 commit dbe7de5

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

cmd/compose/run.go

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -245,10 +245,15 @@ func startDependencies(ctx context.Context, backend api.Service, project types.P
245245

246246
project.Services = dependencies
247247
project.DisabledServices = append(project.DisabledServices, requestedService)
248-
if err := backend.Create(ctx, &project, api.CreateOptions{
248+
err := backend.Create(ctx, &project, api.CreateOptions{
249249
IgnoreOrphans: ignoreOrphans,
250-
}); err != nil {
250+
})
251+
if err != nil {
251252
return err
252253
}
253-
return backend.Start(ctx, project.Name, api.StartOptions{})
254+
255+
if len(dependencies) > 0 {
256+
return backend.Start(ctx, project.Name, api.StartOptions{})
257+
}
258+
return nil
254259
}

pkg/compose/compose.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ func (s *composeService) projectFromName(containers Containers, projectName stri
100100
Name: projectName,
101101
}
102102
if len(containers) == 0 {
103-
return project, errors.New("no such project: " + projectName)
103+
return project, errors.Wrap(api.ErrNotFound, fmt.Sprintf("no container found for project %q", projectName))
104104
}
105105
set := map[string]*types.ServiceConfig{}
106106
for _, c := range containers {

0 commit comments

Comments
 (0)