Skip to content

Commit 9d0adfe

Browse files
committed
Improve logging
1 parent 4f0048a commit 9d0adfe

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

gitpod-network-check/cmd/checks.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ var checkCommand = &cobra.Command{ // nolint:gochecknoglobals
4949
return fmt.Errorf("❌ error creating IAM role and attaching policy: %v", err)
5050
}
5151
Roles = append(Roles, *role.RoleName)
52+
log.Info("✅ IAM role created and policy attached")
5253

5354
instanceProfile, err := createInstanceProfileAndAttachRole(cmd.Context(), iamClient, *role.RoleName)
5455
if err != nil {
@@ -60,7 +61,7 @@ var checkCommand = &cobra.Command{ // nolint:gochecknoglobals
6061
slices.Sort(allSubnets)
6162
distinctSubnets := slices.Compact(allSubnets)
6263
if len(distinctSubnets) < len(allSubnets) {
63-
log.Info("ℹ️ Found duplicate subnets. We'll test each subnet only once, starting with main.")
64+
log.Infof("ℹ️ Found duplicate subnets. We'll test each subnet '%v' only once.", distinctSubnets)
6465
}
6566

6667
log.Infof("ℹ️ Launching EC2 instances in Main subnets")
@@ -256,7 +257,7 @@ func launchInstances(ctx context.Context, ec2Client *ec2.Client, subnets []strin
256257
var instanceIds []string
257258
for _, subnet := range subnets {
258259
if _, ok := Subnets[subnet]; ok {
259-
log.Warnf("Subnet '%v' was already launched, skipping", subnet)
260+
log.Warnf("An EC2 instance was already created for subnet '%v', skipping", subnet)
260261
continue
261262
}
262263
secGroup, err := createSecurityGroups(ctx, ec2Client, subnet)

0 commit comments

Comments
 (0)