Skip to content

Commit d48a8c7

Browse files
authored
Download latest binary & Add CODEOWNERS (#6)
* Download latest binary * Add CODEOWNERS * Check to enable private DNS in VPC endpoints
1 parent 9106ae5 commit d48a8c7

File tree

3 files changed

+12
-2
lines changed

3 files changed

+12
-2
lines changed

.github/CODEOWNERS

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
* @gitpod-io/team-engine @gitpod-io/team-enterprise

gitpod-network-check/README.md

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,13 @@ A CLI to check if your network setup is suitable for the installation of Gitpod.
44

55
## Prerequisites
66

7-
1. Download the `gitpod-network-check` binary using:
7+
1. Download the latest `gitpod-network-check` binary using:
88
```
9-
curl -L "https://github.com/gitpod-io/enterprise-deployment-toolkit/releases/download/v0.1.3/enterprise-deployment-toolkit_$(uname -s -m | awk '{print $1"_"$2}').tar.gz" | tar -xz
9+
curl -s https://api.github.com/repos/gitpod-io/enterprise-deployment-toolkit/releases/latest | \
10+
grep "browser_download_url.*$(uname -s)_$(uname -m)" | \
11+
cut -d : -f 2,3 | \
12+
tr -d \" | \
13+
xargs curl -L | tar -xz
1014
```
1115

1216
You can also download and untar the binary directly from the Github releases page [here](https://github.com/gitpod-io/enterprise-deployment-toolkit/releases/latest)

gitpod-network-check/cmd/checks.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -176,6 +176,11 @@ func checkSMPrerequisites(ctx context.Context, ec2Client *ec2.Client) error {
176176
}
177177
log.Infof("ℹ️ VPC endpoint %s is not configured", endpoint.Endpoint)
178178
} else {
179+
for _, e := range response.VpcEndpoints {
180+
if e.PrivateDnsEnabled != nil && !*e.PrivateDnsEnabled {
181+
log.Errorf("❌ VPC endpoint '%s' has private DNS disabled, it must be enabled", *e.VpcEndpointId)
182+
}
183+
}
179184
log.Infof("✅ VPC endpoint %s is configured", endpoint.Endpoint)
180185
}
181186
}

0 commit comments

Comments
 (0)