Refactor Release notes init

Add some logging and make sure even if release notes are disabled via config, you can manually show them via the command palette.

Author: filiptronicek

src/extension.ts

@@ -79,13 +79,7 @@ export async function activate(context: vscode.ExtensionContext) {
 		}
 	}));
 
-	if (vscode.workspace.getConfiguration('gitpod').get<boolean>('showReleaseNotes')) {
-		const lastRead = context.globalState.get<string>(ReleaseNotes.RELEASE_NOTES_LAST_READ_KEY);
-		logger.info(`Last read release notes: ${lastRead}`);
-		context.subscriptions.push(new ReleaseNotes(context));
-	} else {
-		logger.info('Release notes are disabled');
-	}
+	context.subscriptions.push(new ReleaseNotes(context, logger));
 
 	if (!context.globalState.get<boolean>(FIRST_INSTALL_KEY, false)) {
 		await context.globalState.update(FIRST_INSTALL_KEY, true);

src/releaseNotes.ts

@@ -7,6 +7,7 @@ import * as vscode from 'vscode';
 import { load } from 'js-yaml';
 import { CacheHelper } from './common/cache';
 import { Disposable, disposeAll } from './common/dispose';
+import Log from './common/logger';
 
 export class ReleaseNotes extends Disposable {
 	public static readonly viewType = 'gitpodReleaseNotes';
@@ -20,14 +21,20 @@ export class ReleaseNotes extends Disposable {
 
 	constructor(
 		private readonly context: vscode.ExtensionContext,
+		private readonly logger: Log,
 	) {
 		super();
 
 		this.lastReadId = this.context.globalState.get<string>(ReleaseNotes.RELEASE_NOTES_LAST_READ_KEY);
 
 		this._register(vscode.commands.registerCommand('gitpod.showReleaseNotes', () => this.createOrShow()));
 
-		this.showIfNewRelease(this.lastReadId);
+		const releaseNotesEnabled = vscode.workspace.getConfiguration('gitpod').get<boolean>('showReleaseNotes');
+		if (releaseNotesEnabled) {
+			this.showIfNewRelease(this.lastReadId);
+		} else {
+			logger.info('Release notes are disabled');
+		}
 	}
 
 	private async getLastPublish() {
@@ -158,14 +165,12 @@ export class ReleaseNotes extends Disposable {
 	}
 
 	private async showIfNewRelease(lastReadId: string | undefined) {
-		const showReleaseNotes = vscode.workspace.getConfiguration('gitpod').get<boolean>('showReleaseNotes');
-		if (showReleaseNotes) {
+			this.logger.info(`Last read release notes: ${lastReadId}`);
 			const releaseId = await this.getLastPublish();
 			if (releaseId && releaseId !== lastReadId) {
-				console.log(`gitpod release notes lastReadId: ${lastReadId}, latestReleaseId: ${releaseId}`);
+				this.logger.info(`gitpod release notes lastReadId: ${lastReadId}, latestReleaseId: ${releaseId}`);
 				this.createOrShow();
 			}
-		}
 	}
 
 	public createOrShow() {