Better error message for url exception

jeanp413 · jeanp413 · commit 2c9887a6424a · 2023-10-13T01:11:02.000-05:00
diff --git a/src/common/telemetry.ts b/src/common/telemetry.ts
@@ -64,9 +64,13 @@ export function createSegmentAnalyticsClient(settings: AnalyticsSettings, gitpod
 }
 
 
-export function getErrorMetricsEndpoint(gitpodHost: string): string {
-	const serviceUrl = new URL(gitpodHost);
-	return `https://ide.${serviceUrl.hostname}/metrics-api/reportError`;
+function getErrorMetricsEndpoint(gitpodHost: string): string {
+	try {
+		const serviceUrl = new URL(gitpodHost);
+		return `https://ide.${serviceUrl.hostname}/metrics-api/reportError`;
+	} catch {
+		throw new Error(`Invalid URL: ${gitpodHost}`);
+	}
 }
 
 export async function commonSendEventData(logService: ILogService, segmentClient: Analytics | undefined, machineId: string, eventName: string, data?: any): Promise<void> {

Original file line number	Diff line number	Diff line change
`@@ -64,9 +64,13 @@ export function createSegmentAnalyticsClient(settings: AnalyticsSettings, gitpod`
`64`	`64`	`}`
`65`	`65`
`66`	`66`
`67`		`-export function getErrorMetricsEndpoint(gitpodHost: string): string {`
`68`		`- const serviceUrl = new URL(gitpodHost);`
`69`		- return `https://ide.${serviceUrl.hostname}/metrics-api/reportError`;
	`67`	`+function getErrorMetricsEndpoint(gitpodHost: string): string {`
	`68`	`+ try {`
	`69`	`+ const serviceUrl = new URL(gitpodHost);`
	`70`	+ return `https://ide.${serviceUrl.hostname}/metrics-api/reportError`;
	`71`	`+ } catch {`
	`72`	+ throw new Error(`Invalid URL: ${gitpodHost}`);
	`73`	`+ }`
`70`	`74`	`}`
`71`	`75`
`72`	`76`	`export async function commonSendEventData(logService: ILogService, segmentClient: Analytics \| undefined, machineId: string, eventName: string, data?: any): Promise<void> {`