Skip to content

Commit 4c694d6

Browse files
committed
improve notifications and init local extensions analytics
- use the same status for success in init local extenions - use the same status for hidding notifications to allow break down by actions
1 parent 4fa6b66 commit 4c694d6

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/notification.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,8 @@ export class NotificationService {
5252
} finally {
5353
const duration = new Date().getTime() - startTime;
5454
const closed = result === undefined || (typeof result === 'object' && result.isCloseAffordance === true);
55-
const status = closed ? 'close_' + element : 'select_' + element + '_action';
5655
const action = typeof result === 'string' ? result : result?.title;
57-
this.telemetry.sendUserFlowStatus(status, { ...flowOptions, action, duration });
56+
this.telemetry.sendUserFlowStatus('hide_' + element, { ...flowOptions, action, duration, closed });
5857
}
5958
return result;
6059
}

src/remoteConnector.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -990,8 +990,9 @@ export default class RemoteConnector extends Disposable {
990990
}
991991

992992
extensions = extensions.filter(e => e.installed);
993+
flow.extensions = extensions.length;
993994
if (!extensions.length) {
994-
this.telemetry.sendUserFlowStatus('nothing_to_sync', flow);
995+
this.telemetry.sendUserFlowStatus('synced', flow);
995996
return;
996997
}
997998

0 commit comments

Comments
 (0)