Don't sanitized some telemetry events

Author: jeanp413

src/authentication.ts

@@ -186,7 +186,7 @@ export default class GitpodAuthenticationProvider extends Disposable implements
 			// For the Gitpod scope list, order doesn't matter so we immediately sort the scopes
 			const sortedScopes = scopes.sort();
 
-			this._telemetry.sendTelemetryEvent('gitpod_desktop_auth', {
+			this._telemetry.sendRawTelemetryEvent('gitpod_desktop_auth', {
 				kind: 'login',
 				scopes: JSON.stringify(sortedScopes),
 			});
@@ -208,17 +208,17 @@ export default class GitpodAuthenticationProvider extends Disposable implements
 
 			this._logger.info('Login success!');
 
-			this._telemetry.sendTelemetryEvent('gitpod_desktop_auth', { kind: 'login_successful' });
+			this._telemetry.sendRawTelemetryEvent('gitpod_desktop_auth', { kind: 'login_successful' });
 
 			return session;
 		} catch (e) {
 			// If login was cancelled, do not notify user.
 			if (e === 'Cancelled' || e.message === 'Cancelled') {
-				this._telemetry.sendTelemetryEvent('gitpod_desktop_auth', { kind: 'login_cancelled' });
+				this._telemetry.sendRawTelemetryEvent('gitpod_desktop_auth', { kind: 'login_cancelled' });
 				throw e;
 			}
 
-			this._telemetry.sendTelemetryEvent('gitpod_desktop_auth', { kind: 'login_failed' });
+			this._telemetry.sendRawTelemetryEvent('gitpod_desktop_auth', { kind: 'login_failed' });
 
 			vscode.window.showErrorMessage(`Sign in failed: ${e}`);
 			this._logger.error(e);
@@ -238,7 +238,7 @@ export default class GitpodAuthenticationProvider extends Disposable implements
 
 	public async removeSession(id: string) {
 		try {
-			this._telemetry.sendTelemetryEvent('gitpod_desktop_auth', { kind: 'logout' });
+			this._telemetry.sendRawTelemetryEvent('gitpod_desktop_auth', { kind: 'logout' });
 
 			this._logger.info(`Logging out of ${id}`);
 
@@ -255,7 +255,7 @@ export default class GitpodAuthenticationProvider extends Disposable implements
 				this._logger.error('Session not found');
 			}
 		} catch (e) {
-			this._telemetry.sendTelemetryEvent('gitpod_desktop_auth', { kind: 'logout_failed' });
+			this._telemetry.sendRawTelemetryEvent('gitpod_desktop_auth', { kind: 'logout_failed' });
 
 			vscode.window.showErrorMessage(`Sign out failed: ${e}`);
 			this._logger.error(e);

src/remoteConnector.ts

@@ -701,7 +701,7 @@ export default class RemoteConnector extends Disposable {
 
 				this.telemetry.sendTelemetryEvent('vscode_desktop_ssh', { kind: 'gateway', status: 'connected', ...params });
 			} catch (e) {
-				this.telemetry.sendTelemetryEvent('vscode_desktop_ssh', { kind: 'gateway', status: 'failed', reason: e.toString(), ...params });
+				this.telemetry.sendRawTelemetryEvent('vscode_desktop_ssh', { kind: 'gateway', status: 'failed', reason: e.toString(), ...params });
 				if (e instanceof NoSSHGatewayError) {
 					this.logger.error('No SSH gateway:', e);
 					vscode.window.showWarningMessage(`${e.host} does not support [direct SSH access](https://github.com/gitpod-io/gitpod/blob/main/install/installer/docs/workspace-ssh-access.md), connecting via the deprecated SSH tunnel over WebSocket.`);
@@ -741,9 +741,9 @@ export default class RemoteConnector extends Disposable {
 
 				this.telemetry.sendTelemetryEvent('vscode_desktop_ssh', { kind: 'local-app', status: 'connected', ...params });
 			} catch (e) {
+				this.telemetry.sendRawTelemetryEvent('vscode_desktop_ssh', { kind: 'local-app', status: 'failed', reason: e.toString(), ...params });
 				this.logger.error(`Failed to connect ${params.workspaceId} Gitpod workspace:`, e);
 				if (e instanceof LocalAppError) {
-					this.telemetry.sendTelemetryEvent('vscode_desktop_ssh', { kind: 'local-app', status: 'failed', reason: e.toString(), ...params });
 					const seeLogs = 'See Logs';
 					const showTroubleshooting = 'Show Troubleshooting';
 					const action = await vscode.window.showErrorMessage(`Failed to connect to ${params.workspaceId} Gitpod workspace`, seeLogs, showTroubleshooting);
@@ -758,7 +758,6 @@ export default class RemoteConnector extends Disposable {
 					}
 				} else {
 					// Do nothing, user cancelled the operation
-					this.telemetry.sendTelemetryEvent('vscode_desktop_ssh', { kind: 'local-app', status: 'failed', reason: 'cancelled' });
 				}
 				return;
 			}