Skip to content

Commit 5ec1efd

Browse files
committed
Ignore onDidChangeConfiguration false positive
Related gitpod-io/gitpod#17224
1 parent cd9f185 commit 5ec1efd

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

src/settingsSync.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -117,6 +117,12 @@ export class SettingsSync extends Disposable {
117117

118118
this._register(vscode.workspace.onDidChangeConfiguration(async e => {
119119
if (e.affectsConfiguration('gitpod.host') || e.affectsConfiguration('configurationSync.store')) {
120+
if (e.affectsConfiguration('git') && e.affectsConfiguration('javascript')) {
121+
// Seems onDidChangeConfiguration fires many times while resolving the remote (once with all settings),
122+
// and because now we active the extension earlier with onResolveRemoteAuthority we get this false positive
123+
// event, so ignore it if more settings are affected at the same time.
124+
return;
125+
}
120126
const gitpodHost = this.getServiceUrl().origin;
121127
const flow = { ...this.flow, gitpodHost };
122128
const addedSyncProvider = await this.updateSyncContext();

0 commit comments

Comments
 (0)