Set default config for stable builds during CI (#18)

Co-authored-by: jeanp413 <[email protected]>

Author: filiptronicek

.github/workflows/nightly.yml

@@ -30,12 +30,9 @@ jobs:
 
       - name: Generate package.json
         run: |
+          set -e
           node ./scripts/prepare-nightly-build.js -v ${{ github.event.inputs.patchVersion }}
-
-      - name: Override package.json
-        run: |
-          mv ./package.json ./package.json.bak
-          mv ./package.insiders.json ./package.json
+          mv package.insiders.json package.json
 
       - name: Package extension
         id: package_vsix

.github/workflows/release.yml

@@ -25,6 +25,12 @@ jobs:
           cat package.json | jq "${jqCommands}" > package.json.tmp
           mv package.json.tmp package.json
 
+      - name: Generate package.json
+        run: |
+          set -e
+          node ./scripts/prepare-release-build.js
+          mv package.release.json package.json
+
       - name: Package extension
         id: package_vsix
         run: |

.gitignore

@@ -3,4 +3,4 @@ out/
 .vscode-test/
 *.vsix
 .DS_Store
-package.insiders.json
+package.*.json

.vscodeignore

@@ -12,4 +12,4 @@ yarn.lock
 .eslintrc.json
 .gitpod.yml
 webpack.config.js
-package.insiders.json
+package.*.json

docs/releasing.md

@@ -2,9 +2,6 @@
 
 1. Edit version in [package.json](https://github.com/gitpod-io/gitpod-vscode-desktop/blob/master/package.json)
     - Update version of the extension - this is usually the minor version. **Until the marketplace supports semantic versioning, the minor version should always be an even number. Odd numbers are reserved for the pre-release version of the extension.**
-    - Turn off experimental settings:
-      - `gitpod.remote.useLocalApp: true`
-      - `gitpod.remote.syncExtensions: false`
     - (If necessary) Update vscode engine version
 
 2. If the minor version was increased, run the Nightly action to ensure a new pre-release version with the increased version number is released

scripts/prepare-nightly-build.js

@@ -30,4 +30,4 @@ const insiderPackageJson = Object.assign(json, {
     version: `${major}.${Number(minor) + 1}.${patch}`
 });
 
-fs.writeFileSync('./package.insiders.json', JSON.stringify(insiderPackageJson, undefined, '\t'));
+fs.writeFileSync('./package.insiders.json', JSON.stringify(insiderPackageJson, undefined, '\t') + '\n');

scripts/prepare-release-build.js

@@ -0,0 +1,17 @@
+//@ts-check
+
+const fs = require("fs");
+
+const releasePackageJson = JSON.parse(fs.readFileSync('./package.json').toString());
+
+const releaseDefaultConfig = new Map([
+    ["gitpod.remote.useLocalApp", true],
+    ["gitpod.remote.syncExtensions", false],
+]);
+
+const gitpodConfig = releasePackageJson.contributes.configuration.find(e => e.title.toLowerCase() === 'gitpod');
+for (const [setting, value] of releaseDefaultConfig) {
+    gitpodConfig.properties[setting].default = value;
+}
+
+fs.writeFileSync('./package.release.json', JSON.stringify(releasePackageJson, undefined, '\t') + '\n');