Check if ssh config file is a file before read it

Author: mustard-mh

src/common/files.ts

@@ -17,6 +17,15 @@ export async function exists(path: string) {
     }
 }
 
+export async function isFile(path: string) {
+    try {
+        const s = await fs.promises.stat(path);
+        return s.isFile();
+    } catch {
+        return false;
+    }
+}
+
 export function untildify(path: string){
 	return path.replace(/^~(?=$|\/|\\)/, homeDir);
 }

src/ssh/sshConfig.ts

@@ -8,7 +8,7 @@ import * as fs from 'fs';
 import * as path from 'path';
 import SSHConfig, { Line, Section } from 'ssh-config';
 import * as vscode from 'vscode';
-import { exists as fileExists } from '../common/files';
+import { isFile } from '../common/files';
 import { isWindows } from '../common/platform';
 
 const systemSSHConfig = isWindows ? path.resolve(process.env.ALLUSERSPROFILE || 'C:\\ProgramData', 'ssh\\ssh_config') : '/etc/ssh/ssh_config';
@@ -28,12 +28,12 @@ export default class SSHConfiguration {
     static async loadFromFS(): Promise<SSHConfiguration> {
         const sshConfigPath = getSSHConfigPath();
         let content = '';
-        if (await fileExists(sshConfigPath)) {
+        if (await isFile(sshConfigPath)) {
             content = (await fs.promises.readFile(sshConfigPath, 'utf8')).trim();
         }
         const config = SSHConfig.parse(content);
 
-        if (await fileExists(systemSSHConfig)) {
+        if (await isFile(systemSSHConfig)) {
             content = (await fs.promises.readFile(systemSSHConfig, 'utf8')).trim();
             config.push(...SSHConfig.parse(content));
         }