Skip to content

Commit b4e1de8

Browse files
committed
More workspace explorer feedback
1 parent 64536d7 commit b4e1de8

File tree

4 files changed

+280
-41
lines changed

4 files changed

+280
-41
lines changed

package.json

Lines changed: 88 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -126,43 +126,68 @@
126126
{
127127
"command": "gitpod.workspaces.connectInNewWindow",
128128
"category": "Gitpod",
129-
"title": "Open in New Window...",
130-
"icon": "$(empty-window)"
129+
"title": "Open Workspace in New Window"
130+
},
131+
{
132+
"command": "gitpod.workspaces.connectInNewWindow_context",
133+
"category": "Gitpod",
134+
"title": "Open in New Window"
131135
},
132136
{
133137
"command": "gitpod.workspaces.connectInCurrentWindow",
134138
"category": "Gitpod",
135-
"title": "Open...",
136-
"icon": "$(arrow-right)"
139+
"title": "Connect to Workspace"
140+
},
141+
{
142+
"command": "gitpod.workspaces.connectInCurrentWindow_context",
143+
"category": "Gitpod",
144+
"title": "Start and Connect"
145+
},
146+
{
147+
"command": "gitpod.workspaces.connectInCurrentWindow_context@1",
148+
"category": "Gitpod",
149+
"title": "Connect"
137150
},
138151
{
139152
"command": "gitpod.workspaces.connectInCurrentWindow_inline",
140153
"category": "Gitpod",
141-
"title": "Open...",
154+
"title": "Start and Connect",
155+
"icon": "$(arrow-right)"
156+
},
157+
{
158+
"command": "gitpod.workspaces.connectInCurrentWindow_inline@1",
159+
"category": "Gitpod",
160+
"title": "Connect",
142161
"icon": "$(arrow-right)"
143162
},
144163
{
145164
"command": "gitpod.workspaces.stopWorkspace",
146165
"category": "Gitpod",
147-
"title": "Stop Workspace...",
166+
"title": "Stop Workspace",
167+
"icon": "$(primitive-square)"
168+
},
169+
{
170+
"command": "gitpod.workspaces.stopWorkspace_context",
171+
"category": "Gitpod",
172+
"title": "Stop",
148173
"icon": "$(primitive-square)"
149174
},
150175
{
151176
"command": "gitpod.workspaces.stopWorkspace_inline",
152177
"category": "Gitpod",
153-
"title": "Stop Workspace...",
178+
"title": "Stop",
154179
"icon": "$(primitive-square)"
155180
},
156181
{
157182
"command": "gitpod.workspaces.stopCurrentWorkspace",
158183
"category": "Gitpod",
159-
"title": "Stop Current Workspace",
184+
"title": "Disconnect and Stop",
160185
"icon": "$(primitive-square)"
161186
},
162187
{
163188
"command": "gitpod.workspaces.openInBrowser",
164189
"category": "Gitpod",
165-
"title": "Open in Browser..."
190+
"title": "Open in Browser"
166191
},
167192
{
168193
"command": "gitpod.workspaces.openContext",
@@ -172,12 +197,17 @@
172197
{
173198
"command": "gitpod.workspaces.deleteWorkspace",
174199
"category": "Gitpod",
175-
"title": "Delete Workspace..."
200+
"title": "Delete Workspace"
201+
},
202+
{
203+
"command": "gitpod.workspaces.deleteWorkspace_context",
204+
"category": "Gitpod",
205+
"title": "Delete"
176206
},
177207
{
178208
"command": "gitpod.workspaces.disconnect",
179209
"category": "Gitpod",
180-
"title": "Close Remote Connection",
210+
"title": "Disconnect",
181211
"icon": "$(debug-disconnect)"
182212
}
183213
],
@@ -199,7 +229,12 @@
199229
"view/item/context": [
200230
{
201231
"command": "gitpod.workspaces.connectInCurrentWindow_inline",
202-
"when": "viewItem =~ /^gitpod-workspaces.workspace(?:.running)?$/",
232+
"when": "viewItem =~ /^gitpod-workspaces.workspace$/",
233+
"group": "inline@1"
234+
},
235+
{
236+
"command": "gitpod.workspaces.connectInCurrentWindow_inline@1",
237+
"when": "viewItem =~ /^gitpod-workspaces.workspace.running$/",
203238
"group": "inline@1"
204239
},
205240
{
@@ -213,12 +248,22 @@
213248
"group": "inline@3"
214249
},
215250
{
216-
"command": "gitpod.workspaces.connectInCurrentWindow",
217-
"when": "viewItem =~ /^gitpod-workspaces.workspace/",
251+
"command": "gitpod.workspaces.stopCurrentWorkspace",
252+
"when": "viewItem =~ /^gitpod-workspaces.workspace.+connected$/",
253+
"group": "inline@4"
254+
},
255+
{
256+
"command": "gitpod.workspaces.connectInCurrentWindow_context",
257+
"when": "viewItem =~ /^gitpod-workspaces.workspace$/",
218258
"group": "navigation@1"
219259
},
220260
{
221-
"command": "gitpod.workspaces.connectInNewWindow",
261+
"command": "gitpod.workspaces.connectInCurrentWindow_context@1",
262+
"when": "viewItem =~ /^gitpod-workspaces.workspace.running$/",
263+
"group": "navigation@1"
264+
},
265+
{
266+
"command": "gitpod.workspaces.connectInNewWindow_context",
222267
"when": "viewItem =~ /^gitpod-workspaces.workspace/",
223268
"group": "navigation@2"
224269
},
@@ -233,12 +278,12 @@
233278
"group": "navigation@4"
234279
},
235280
{
236-
"command": "gitpod.workspaces.stopWorkspace",
281+
"command": "gitpod.workspaces.stopWorkspace_context",
237282
"when": "viewItem =~ /^gitpod-workspaces.workspace.running$/",
238283
"group": "navigation@5"
239284
},
240285
{
241-
"command": "gitpod.workspaces.deleteWorkspace",
286+
"command": "gitpod.workspaces.deleteWorkspace_context",
242287
"when": "viewItem =~ /^gitpod-workspaces.workspace/",
243288
"group": "destruction@1"
244289
}
@@ -256,29 +301,49 @@
256301
"command": "gitpod.workspaces.connectInNewWindow",
257302
"when": "gitpod.authenticated == true"
258303
},
304+
{
305+
"command": "gitpod.workspaces.connectInNewWindow_context",
306+
"when": "false"
307+
},
259308
{
260309
"command": "gitpod.workspaces.connectInCurrentWindow",
261310
"when": "gitpod.authenticated == true"
262311
},
312+
{
313+
"command": "gitpod.workspaces.connectInCurrentWindow_context",
314+
"when": "false"
315+
},
316+
{
317+
"command": "gitpod.workspaces.connectInCurrentWindow_context@1",
318+
"when": "false"
319+
},
263320
{
264321
"command": "gitpod.workspaces.connectInCurrentWindow_inline",
265322
"when": "false"
266323
},
324+
{
325+
"command": "gitpod.workspaces.connectInCurrentWindow_inline@1",
326+
"when": "false"
327+
},
267328
{
268329
"command": "gitpod.workspaces.stopWorkspace",
269330
"when": "gitpod.authenticated == true"
270331
},
332+
{
333+
"command": "gitpod.workspaces.stopWorkspace_context",
334+
"when": "false"
335+
},
271336
{
272337
"command": "gitpod.workspaces.stopWorkspace_inline",
273338
"when": "false"
274339
},
275340
{
276341
"command": "gitpod.workspaces.stopCurrentWorkspace",
277-
"when": "gitpod.authenticated == true && gitpod.inWorkspace == true"
342+
"when": "false"
278343
},
279344
{
280345
"command": "gitpod.workspaces.openInBrowser",
281-
"when": "gitpod.authenticated == true"
346+
"when": "gitpod.authenticated == true && gitpod.inWorkspace == true"
282347
},
283348
{
284349
"command": "gitpod.workspaces.openContext",
@@ -288,6 +353,10 @@
288353
"command": "gitpod.workspaces.deleteWorkspace",
289354
"when": "gitpod.authenticated == true"
290355
},
356+
{
357+
"command": "gitpod.workspaces.deleteWorkspace_context",
358+
"when": "false"
359+
},
291360
{
292361
"command": "gitpod.workspaces.disconnect",
293362
"when": "false"

0 commit comments

Comments
 (0)