Skip to content

Commit c8eaaf0

Browse files
committed
Update deps
1 parent f7d09d9 commit c8eaaf0

File tree

6 files changed

+115
-84
lines changed

6 files changed

+115
-84
lines changed

package.json

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -136,8 +136,6 @@
136136
"test": "mocha -u tdd"
137137
},
138138
"devDependencies": {
139-
"@types/analytics-node": "^3.1.9",
140-
"@types/crypto-js": "4.1.1",
141139
"@types/google-protobuf": "^3.7.4",
142140
"@types/js-yaml": "^4.0.5",
143141
"@types/mocha": "^9.1.1",
@@ -163,12 +161,12 @@
163161
"webpack-cli": "^4.7.2"
164162
},
165163
"dependencies": {
166-
"@bufbuild/connect-node": "^0.7.0",
164+
"@bufbuild/connect-node": "^0.8.4",
167165
"@gitpod/gitpod-protocol": "main",
168166
"@gitpod/local-app-api-grpcweb": "main",
169167
"@gitpod/public-api": "^0.1.5-main.6530",
170168
"@improbable-eng/grpc-web-node-http-transport": "^0.14.0",
171-
"analytics-node": "^6.2.0",
169+
"@segment/analytics-node": "^1.0.0-beta.24",
172170
"configcat-node": "^8.0.0",
173171
"js-yaml": "^4.1.0",
174172
"node-fetch-commonjs": "^3.2.4",

src/common/telemetry.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -429,8 +429,8 @@ export class BaseTelemetryReporter extends Disposable {
429429
}
430430
}
431431

432-
public override async dispose(): Promise<any> {
433-
await this.telemetryAppender.flush();
432+
public override async dispose(): Promise<void> {
434433
super.dispose();
434+
await this.telemetryAppender.flush();
435435
}
436436
}

src/metrics.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,8 @@
66
import * as vscode from 'vscode';
77
import * as grpc from '@grpc/grpc-js';
88
import { Registry, Counter, Histogram, metric } from 'prom-client';
9-
import { Code, connectErrorFromReason, Interceptor, StreamRequest, UnaryRequest } from '@bufbuild/connect-node';
109
import { MethodKind } from '@bufbuild/protobuf';
11-
import { StreamResponse, UnaryResponse } from '@bufbuild/connect-core';
10+
import { StreamResponse, UnaryResponse, Code, connectErrorFromReason, Interceptor, StreamRequest, UnaryRequest } from '@bufbuild/connect';
1211

1312
export type GrpcMethodType = 'unary' | 'client_stream' | 'server_stream' | 'bidi_stream';
1413

src/publicApi.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@
33
* Licensed under the MIT License. See License.txt in the project root for license information.
44
*--------------------------------------------------------------------------------------------*/
55

6-
import { createConnectTransport, createPromiseClient, Interceptor, PromiseClient } from '@bufbuild/connect-node';
6+
import { createConnectTransport } from '@bufbuild/connect-node';
7+
import { createPromiseClient, Interceptor, PromiseClient } from '@bufbuild/connect';
78
import { WorkspacesService } from '@gitpod/public-api/lib/gitpod/experimental/v1/workspaces_connectweb';
89
import { IDEClientService } from '@gitpod/public-api/lib/gitpod/experimental/v1/ide_client_connectweb';
910
import { UserService } from '@gitpod/public-api/lib/gitpod/experimental/v1/user_connectweb';

src/telemetryReporter.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,12 @@
44
*--------------------------------------------------------------------------------------------*/
55

66
import { AppenderData, BaseTelemetryAppender, BaseTelemetryClient, BaseTelemetryReporter } from './common/telemetry';
7-
import SegmentAnalytics from 'analytics-node';
7+
import { Analytics } from '@segment/analytics-node';
88
import * as os from 'os';
99
import * as vscode from 'vscode';
1010

1111
const analyticsClientFactory = async (key: string): Promise<BaseTelemetryClient> => {
12-
let segmentAnalyticsClient = new SegmentAnalytics(key);
12+
let segmentAnalyticsClient = new Analytics({ writeKey: key });
1313

1414
// Sets the analytics client into a standardized form
1515
const telemetryClient: BaseTelemetryClient = {
@@ -34,8 +34,8 @@ const analyticsClientFactory = async (key: string): Promise<BaseTelemetryClient>
3434
properties['error_message'] = exception.message;
3535
properties['debug_workspace'] = String(properties['debug_workspace'] ?? false);
3636

37-
const workspaceId = properties['workspaceId'] ?? '';
38-
const instanceId = properties['instanceId'] ?? '';
37+
const workspaceId = properties['workspaceId'] ?? '';
38+
const instanceId = properties['instanceId'] ?? '';
3939
const userId = properties['userId'] ?? '';
4040

4141
delete properties['workspaceId'];
@@ -67,7 +67,7 @@ const analyticsClientFactory = async (key: string): Promise<BaseTelemetryClient>
6767
},
6868
flush: async () => {
6969
try {
70-
await segmentAnalyticsClient.flush();
70+
await segmentAnalyticsClient.closeAndFlush({ timeout: 3000 });
7171
} catch (e: any) {
7272
console.error('Failed to flush app analytics!', e);
7373
}

0 commit comments

Comments
 (0)