Introduce enterprise_onboarding_enabled flag

Author: filiptronicek

components/dashboard/src/data/featureflag-query.ts

@@ -24,6 +24,7 @@ const featureFlags = {
     showBrowserExtensionPromotion: false,
     enable_experimental_jbtb: false,
     enabled_configuration_prebuild_full_clone: false,
+    enterprise_onboarding_enabled: false,
 };
 
 type FeatureFlags = typeof featureFlags;

components/dashboard/src/teams/OrgSettingsPage.tsx

@@ -15,7 +15,7 @@ import { useCurrentOrg } from "../data/organizations/orgs-query";
 import { useFeatureFlag } from "../data/featureflag-query";
 import { Organization } from "@gitpod/public-api/lib/gitpod/v1/organization_pb";
 import { useIsOwner } from "../data/organizations/members-query";
-import { isGitpodIo } from "../utils";
+import { useInstallationConfiguration } from "../data/installation/default-workspace-image-query";
 
 export interface OrgSettingsPageProps {
     children: React.ReactNode;
@@ -27,6 +27,9 @@ export function OrgSettingsPage({ children }: OrgSettingsPageProps) {
     const orgBillingMode = useOrgBillingMode();
     const oidcServiceEnabled = useFeatureFlag("oidcServiceEnabled");
     const orgGitAuthProviders = useFeatureFlag("orgGitAuthProviders");
+    const isOnboardingEnabled = useFeatureFlag("enterprise_onboarding_enabled");
+    const { data: installationConfig } = useInstallationConfiguration();
+    const isDedicatedInstallation = !!installationConfig?.isDedicatedInstallation;
 
     const menu = useMemo(
         () =>
@@ -36,8 +39,18 @@ export function OrgSettingsPage({ children }: OrgSettingsPageProps) {
                 ssoEnabled: oidcServiceEnabled,
                 orgGitAuthProviders,
                 isOwner,
+                isDedicatedInstallation,
+                showOnboarding: isOnboardingEnabled && isDedicatedInstallation,
             }),
-        [org.data, orgBillingMode.data, oidcServiceEnabled, orgGitAuthProviders, isOwner],
+        [
+            org.data,
+            orgBillingMode.data,
+            oidcServiceEnabled,
+            orgGitAuthProviders,
+            isOwner,
+            isDedicatedInstallation,
+            isOnboardingEnabled,
+        ],
     );
 
     const title = "Organization Settings";
@@ -76,8 +89,10 @@ function getOrgSettingsMenu(params: {
     ssoEnabled?: boolean;
     orgGitAuthProviders: boolean;
     isOwner?: boolean;
+    showOnboarding?: boolean;
+    isDedicatedInstallation?: boolean;
 }) {
-    const { billingMode, ssoEnabled, orgGitAuthProviders, isOwner } = params;
+    const { billingMode, ssoEnabled, orgGitAuthProviders, isOwner, showOnboarding, isDedicatedInstallation } = params;
     const result = [
         {
             title: "General",
@@ -87,12 +102,8 @@ function getOrgSettingsMenu(params: {
             title: "Policies",
             link: [`/settings/policy`],
         },
-        {
-            title: "Onboarding",
-            link: [`/settings/onboarding`],
-        },
     ];
-    if (isGitpodIo()) {
+    if (!isDedicatedInstallation) {
         result.push(
             {
                 title: "Networking",
@@ -104,6 +115,12 @@ function getOrgSettingsMenu(params: {
             },
         );
     }
+    if (showOnboarding) {
+        result.push({
+            title: "Onboarding",
+            link: [`/settings/onboarding`],
+        });
+    }
     if (isOwner && ssoEnabled) {
         result.push({
             title: "SSO",

components/server/src/api/organization-service-api.ts

@@ -46,10 +46,13 @@ import { validate as uuidValidate } from "uuid";
 import { ctxUserId } from "../util/request-context";
 import { ApplicationError, ErrorCodes } from "@gitpod/gitpod-protocol/lib/messaging/error";
 import { EntitlementService } from "../billing/entitlement-service";
+import { Config } from "../config";
 
 @injectable()
 export class OrganizationServiceAPI implements ServiceImpl<typeof OrganizationServiceInterface> {
     constructor(
+        @inject(Config)
+        private readonly config: Config,
         @inject(OrganizationService)
         private readonly orgService: OrganizationService,
         @inject(PublicAPIConverter)
@@ -335,6 +338,16 @@ export class OrganizationServiceAPI implements ServiceImpl<typeof OrganizationSe
         }
 
         if (req.onboardingSettings) {
+            if (!this.config.isDedicatedInstallation) {
+                throw new ApplicationError(
+                    ErrorCodes.BAD_REQUEST,
+                    "onboardingSettings can only be set on enterprise installations",
+                );
+            }
+            if (req.onboardingSettings.internalLink?.length ?? 0 > 255) {
+                throw new ApplicationError(ErrorCodes.BAD_REQUEST, "internalLink must be <= 255 characters");
+            }
+
             update.onboardingSettings = req.onboardingSettings;
         }