fix unit tests

Author: mustard-mh

components/supervisor/pkg/ports/ports.go

@@ -46,7 +46,7 @@ func NewManager(exposed ExposedPortsInterface, served ServedPortsObserver, confi
 		T: tunneled,
 
 		forceUpdates:       make(chan struct{}, 1),
-		closeSubscriptions: make(chan *Subscription, maxSubscriptions),
+		closeSubscriptions: make(chan *Subscription, maxSubscriptions*2),
 
 		internal:     internal,
 		proxies:      make(map[uint32]*localhostProxy),
@@ -772,7 +772,8 @@ func (pm *Manager) Subscribe() (*Subscription, error) {
 	}
 
 	if len(pm.subscriptions) > maxSubscriptions {
-		return nil, ErrTooManySubscriptions
+		return nil, fmt.Errorf("too many subscriptions: %d", len(pm.subscriptions))
+		// return nil, ErrTooManySubscriptions
 	}
 
 	sub := &Subscription{updates: make(chan []*api.PortsStatus, 5)}

components/supervisor/pkg/ports/ports_test.go

@@ -864,8 +864,8 @@ func TestPortsConcurrentSubscribe(t *testing.T) {
 		}
 	}()
 
-	eg, _ := errgroup.WithContext(context.Background())
 	for i := 0; i < maxSubscriptions; i++ {
+		eg, _ := errgroup.WithContext(context.Background())
 		eg.Go(func() error {
 			for j := 0; j < subscribes; j++ {
 				sub, err := pm.Subscribe()
@@ -882,12 +882,13 @@ func TestPortsConcurrentSubscribe(t *testing.T) {
 			}
 			return nil
 		})
+		err := eg.Wait()
+		if err != nil {
+			t.Fatal(err)
+		}
+		time.Sleep(50 * time.Millisecond)
 	}
-	err := eg.Wait()
 	close(subscribing)
-	if err != nil {
-		t.Fatal(err)
-	}
 
 	wg.Wait()
 }