Remove obsolete node labels for ws-daemon and registry-facade readiness

Removes the node labels `gitpod.io/ws-daemon_ready_ns_*` and `gitpod.io/registry-facade_ready_ns_*` as they are no longer necessary since workspace scheduling now relies on taints instead of positive labels.

Changes:
- ws-manager-mk2: Remove NodeSelectorRequirements for obsolete labels
- node-labeler: Remove label constants and management logic while preserving taint functionality
- Documentation: Update to reflect taint-based scheduling approach

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

Author: kylos101

components/node-labeler/cmd/run.go

@@ -44,9 +44,6 @@ import (
 )
 
 const (
-	registryFacadeLabel = "gitpod.io/registry-facade_ready_ns_%v"
-	wsdaemonLabel       = "gitpod.io/ws-daemon_ready_ns_%v"
-
 	registryFacade = "registry-facade"
 	wsDaemon       = "ws-daemon"
 
@@ -351,10 +348,6 @@ func (r *NodeReconciler) reconcileAll(ctx context.Context) error {
 			continue
 		}
 
-		err := updateNodeLabel(node.Name, r.Client)
-		if err != nil {
-			log.WithError(err).WithField("node", node.Name).Error("failed to initialize labels on node")
-		}
 		r.Reconcile(ctx, reconcile.Request{NamespacedName: types.NamespacedName{Name: node.Name}})
 	}
 
@@ -378,10 +371,6 @@ func (r *NodeReconciler) Reconcile(ctx context.Context, req reconcile.Request) (
 	if err != nil {
 		return reconcile.Result{}, fmt.Errorf("cannot list pods: %w", err)
 	}
-	err = updateNodeLabel(node.Name, r.Client)
-	if err != nil {
-		log.WithError(err).WithField("node", node.Name).Error("failed to initialize labels on node")
-	}
 	isWsdaemonTaintExists := isNodeTaintExists(wsDaemonTaintKey, node)
 	isRegistryFacadeTaintExists := isNodeTaintExists(registryFacadeTaintKey, node)
 	isWsDaemonReady, isRegistryFacadeReady := false, false
@@ -735,45 +724,3 @@ func isWorkspaceNode(node corev1.Node) bool {
 	_, isHeadlessWorkspaceNode := node.Labels[workspacesHeadlessLabel]
 	return isRegularWorkspaceNode || isHeadlessWorkspaceNode
 }
-
-func updateNodeLabel(nodeName string, client client.Client) error {
-	return retry.RetryOnConflict(retry.DefaultBackoff, func() error {
-		ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second)
-		defer cancel()
-
-		var node corev1.Node
-		err := client.Get(ctx, types.NamespacedName{Name: nodeName}, &node)
-		if err != nil {
-			return err
-		}
-
-		registryFacadeLabelForNamespace := fmt.Sprintf(registryFacadeLabel, namespace)
-		wsDaemonLabelForNamespace := fmt.Sprintf(wsdaemonLabel, namespace)
-
-		needUpdate := false
-
-		if node.Labels == nil {
-			node.Labels = make(map[string]string)
-		}
-
-		if v := node.Labels[registryFacadeLabelForNamespace]; v != "true" {
-			needUpdate = true
-		}
-		if v := node.Labels[wsDaemonLabelForNamespace]; v != "true" {
-			needUpdate = true
-		}
-
-		if !needUpdate {
-			return nil
-		}
-		node.Labels[registryFacadeLabelForNamespace] = "true"
-		node.Labels[wsDaemonLabelForNamespace] = "true"
-
-		err = client.Update(ctx, &node)
-		if err != nil {
-			return err
-		}
-
-		return nil
-	})
-}

components/ws-manager-mk2/controllers/create.go

@@ -339,14 +339,6 @@ func createDefiniteWorkspacePod(sctx *startWorkspaceContext) (*corev1.Pod, error
 			Key:      "gitpod.io/workload_workspace_" + workloadType,
 			Operator: corev1.NodeSelectorOpExists,
 		},
-		{
-			Key:      "gitpod.io/ws-daemon_ready_ns_" + sctx.Config.Namespace,
-			Operator: corev1.NodeSelectorOpExists,
-		},
-		{
-			Key:      "gitpod.io/registry-facade_ready_ns_" + sctx.Config.Namespace,
-			Operator: corev1.NodeSelectorOpExists,
-		},
 	}
 
 	affinity := &corev1.Affinity{

memory-bank/components/node-labeler.md

@@ -77,12 +77,12 @@ The Node-Labeler component integrates with:
 
 ## Usage Patterns
 
-### Node Label Management
-The component adds the following labels to nodes:
-- `gitpod.io/registry-facade_ready_ns_<namespace>`: Indicates registry-facade is ready
-- `gitpod.io/ws-daemon_ready_ns_<namespace>`: Indicates ws-daemon is ready
+### Node Taint Management
+The component manages node taints to control workspace scheduling:
+- `gitpod.io/registry-facade-not-ready`: Added when registry-facade is not ready
+- `gitpod.io/ws-daemon-not-ready`: Added when ws-daemon is not ready
 
-These labels are used by the workspace scheduler to ensure workspaces are only scheduled on nodes with the required services.
+These taints prevent workspace pods from being scheduled on nodes where required services are not available.
 
 ### Cluster-Autoscaler Annotation Management
 The component adds or removes the following annotation: