Skip to content

Commit 4873403

Browse files
[minio] update minio library to v7
1 parent 396b51e commit 4873403

File tree

13 files changed

+288
-79
lines changed

13 files changed

+288
-79
lines changed

components/content-service/go.mod

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,16 +16,22 @@ require (
1616
github.com/go-ozzo/ozzo-validation v3.5.0+incompatible
1717
github.com/golang/protobuf v1.4.3
1818
github.com/google/go-cmp v0.5.2
19-
github.com/konsorten/go-windows-terminal-sequences v1.0.3 // indirect
20-
github.com/minio/minio-go/v6 v6.0.34
19+
github.com/google/uuid v1.1.4 // indirect
20+
github.com/minio/md5-simd v1.1.1 // indirect
21+
github.com/minio/minio-go/v7 v7.0.7
2122
github.com/opencontainers/go-digest v1.0.0
2223
github.com/opencontainers/image-spec v1.0.1
2324
github.com/opentracing/opentracing-go v1.1.0
24-
github.com/sirupsen/logrus v1.4.2
25+
github.com/sirupsen/logrus v1.7.0
26+
golang.org/x/crypto v0.0.0-20201221181555-eec23a3978ad // indirect
27+
golang.org/x/net v0.0.0-20201224014010-6772e930b67b // indirect
2528
golang.org/x/oauth2 v0.0.0-20200902213428-5d25da1a8d43
29+
golang.org/x/sys v0.0.0-20210110051926-789bb1bd4061 // indirect
30+
golang.org/x/text v0.3.5 // indirect
2631
golang.org/x/xerrors v0.0.0-20200804184101-5ec99f83aff1
2732
google.golang.org/api v0.32.0
2833
google.golang.org/grpc v1.34.0
34+
gopkg.in/ini.v1 v1.62.0 // indirect
2935
)
3036

3137
replace github.com/gitpod-io/gitpod/common-go => ../common-go // leeway

components/content-service/go.sum

Lines changed: 44 additions & 57 deletions
Large diffs are not rendered by default.

components/content-service/pkg/storage/minio.go

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,8 @@ import (
1818
"golang.org/x/xerrors"
1919

2020
validation "github.com/go-ozzo/ozzo-validation"
21-
minio "github.com/minio/minio-go/v6"
21+
minio "github.com/minio/minio-go/v7"
22+
"github.com/minio/minio-go/v7/pkg/credentials"
2223
)
2324

2425
var _ DirectAccess = &DirectMinIOStorage{}
@@ -57,7 +58,10 @@ func (c *MinIOConfig) MinIOClient() (*minio.Client, error) {
5758
return nil, err
5859
}
5960

60-
minioClient, err := minio.New(c.Endpoint, c.AccessKeyID, c.SecretAccessKey, c.Secure)
61+
minioClient, err := minio.New(c.Endpoint, &minio.Options{
62+
Creds: credentials.NewStaticV4(c.AccessKeyID, c.SecretAccessKey, ""),
63+
Secure: c.Secure,
64+
})
6165
if err != nil {
6266
return nil, err
6367
}
@@ -125,7 +129,7 @@ func (rs *DirectMinIOStorage) defaultObjectAccess(ctx context.Context, bkt, obj
125129
return nil, xerrors.Errorf("no MinIO client avialable - did you call Init()?")
126130
}
127131

128-
object, err := rs.client.GetObjectWithContext(ctx, bkt, obj, minio.GetObjectOptions{})
132+
object, err := rs.client.GetObject(ctx, bkt, obj, minio.GetObjectOptions{})
129133
if err != nil {
130134
return nil, translateMinioError(err)
131135
}
@@ -147,7 +151,7 @@ func (rs *DirectMinIOStorage) EnsureExists(ctx context.Context) (err error) {
147151
return xerrors.Errorf("no MinIO client avialable - did you call Init()?")
148152
}
149153

150-
exists, err := rs.client.BucketExists(rs.bucketName())
154+
exists, err := rs.client.BucketExists(ctx, rs.bucketName())
151155
if err != nil {
152156
return err
153157
}
@@ -157,7 +161,7 @@ func (rs *DirectMinIOStorage) EnsureExists(ctx context.Context) (err error) {
157161
}
158162

159163
log.WithField("bucketName", rs.bucketName()).Debug("Creating bucket")
160-
err = rs.client.MakeBucket(rs.bucketName(), rs.MinIOConfig.Region)
164+
err = rs.client.MakeBucket(ctx, rs.bucketName(), minio.MakeBucketOptions{Region: rs.MinIOConfig.Region})
161165
if err != nil {
162166
return xerrors.Errorf("cannot create bucket: %w", err)
163167
}
@@ -224,7 +228,7 @@ func (rs *DirectMinIOStorage) Upload(ctx context.Context, source string, name st
224228
// upload the thing
225229
bucket = rs.bucketName()
226230
obj = rs.objectName(name)
227-
_, err = rs.client.FPutObjectWithContext(ctx, bucket, obj, source, minio.PutObjectOptions{
231+
_, err = rs.client.FPutObject(ctx, bucket, obj, source, minio.PutObjectOptions{
228232
NumThreads: rs.MinIOConfig.ParallelUpload,
229233
UserMetadata: options.Annotations,
230234
ContentType: options.ContentType,
@@ -283,15 +287,15 @@ func (s *presignedMinIOStorage) SignDownload(ctx context.Context, bucket, object
283287
tracing.FinishSpan(span, &err)
284288
}()
285289

286-
obj, err := s.client.GetObject(bucket, object, minio.GetObjectOptions{})
290+
obj, err := s.client.GetObject(ctx, bucket, object, minio.GetObjectOptions{})
287291
if err != nil {
288292
return nil, translateMinioError(err)
289293
}
290294
stat, err := obj.Stat()
291295
if err != nil {
292296
return nil, translateMinioError(err)
293297
}
294-
url, err := s.client.PresignedGetObject(bucket, object, 30*time.Minute, nil)
298+
url, err := s.client.PresignedGetObject(ctx, bucket, object, 30*time.Minute, nil)
295299
if err != nil {
296300
return nil, translateMinioError(err)
297301
}

components/image-builder/go.mod

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,13 +27,13 @@ require (
2727
github.com/gorilla/mux v1.8.0 // indirect
2828
github.com/grpc-ecosystem/go-grpc-middleware v1.0.0
2929
github.com/inconshreveable/mousetrap v1.0.0 // indirect
30-
github.com/mattn/go-isatty v0.0.9
30+
github.com/mattn/go-isatty v0.0.11
3131
github.com/morikuni/aec v1.0.0 // indirect
3232
github.com/opencontainers/go-digest v1.0.0
3333
github.com/opencontainers/image-spec v1.0.1
3434
github.com/opentracing/opentracing-go v1.1.0
3535
github.com/prometheus/client_golang v1.1.0
36-
github.com/sirupsen/logrus v1.4.2
36+
github.com/sirupsen/logrus v1.7.0
3737
github.com/spf13/cobra v0.0.3
3838
golang.org/x/xerrors v0.0.0-20200804184101-5ec99f83aff1
3939
google.golang.org/grpc v1.34.0

0 commit comments

Comments
 (0)