big yellow warning for a thing that should not happen

filiptronicek · filiptronicek · commit 4e3401b9f02a · 2025-01-21T23:03:01.000Z
diff --git a/components/node-labeler/cmd/run.go b/components/node-labeler/cmd/run.go
@@ -410,6 +410,7 @@ func (c *NodeScaledownAnnotationController) Reconcile(ctx context.Context, req c
 		c.queueNodeForReconciliation(ws.Status.Runtime.NodeName)
 	}
 
+	log.WithField("runtime", ws.Status.Runtime).Warn("reconciling object with no Runtime/NodeName, which wasn't filtered out by workspaceFilter")
 	return ctrl.Result{}, nil
 }
 

Original file line number	Diff line number	Diff line change
`@@ -410,6 +410,7 @@ func (c *NodeScaledownAnnotationController) Reconcile(ctx context.Context, req c`
`410`	`410`	`c.queueNodeForReconciliation(ws.Status.Runtime.NodeName)`
`411`	`411`	`}`
`412`	`412`
	`413`	`+ log.WithField("runtime", ws.Status.Runtime).Warn("reconciling object with no Runtime/NodeName, which wasn't filtered out by workspaceFilter")`
`413`	`414`	`return ctrl.Result{}, nil`
`414`	`415`	`}`
`415`	`416`