Revert trigger strategy on webhook event

Author: filiptronicek

components/server/src/prebuilds/bitbucket-app.ts

@@ -130,6 +130,20 @@ export class BitbucketApp {
                 try {
                     const projectOwner = await this.findProjectOwner(project, user);
 
+                    if (project.settings?.prebuilds?.triggerStrategy === "activity-based") {
+                        await this.projectService.updateProject(projectOwner, {
+                            id: project.id,
+                            settings: {
+                                ...project.settings,
+                                prebuilds: {
+                                    ...project.settings.prebuilds,
+                                    triggerStrategy: "webhook-based",
+                                },
+                            },
+                        });
+                        log.info(`Reverted configuration ${project.id} to webhook-based prebuilds`);
+                    }
+
                     const contextURL = this.createContextUrl(data);
                     span.setTag("contextURL", contextURL);
                     const context = (await this.contextParser.handle({ span }, user, contextURL)) as CommitContext;

components/server/src/prebuilds/bitbucket-server-app.ts

@@ -127,6 +127,20 @@ export class BitbucketServerApp {
                 try {
                     const projectOwner = await this.findProjectOwner(project, user);
 
+                    if (project.settings?.prebuilds?.triggerStrategy === "activity-based") {
+                        await this.projectService.updateProject(projectOwner, {
+                            id: project.id,
+                            settings: {
+                                ...project.settings,
+                                prebuilds: {
+                                    ...project.settings.prebuilds,
+                                    triggerStrategy: "webhook-based",
+                                },
+                            },
+                        });
+                        log.info(`Reverted configuration ${project.id} to webhook-based prebuilds`);
+                    }
+
                     const contextUrl = this.createBranchContextUrl(payload);
                     span.setTag("contextUrl", contextUrl);
                     const context = await this.contextParser.handle({ span }, user, contextUrl);

components/server/src/prebuilds/github-app.ts

@@ -289,6 +289,20 @@ export class GithubApp {
                     const user = await this.findProjectOwner(project, installationOwner);
                     const config = await this.prebuildManager.fetchConfig({ span }, user, context, project?.teamId);
 
+                    if (project.settings?.prebuilds?.triggerStrategy === "activity-based") {
+                        await this.projectService.updateProject(user, {
+                            id: project.id,
+                            settings: {
+                                ...project.settings,
+                                prebuilds: {
+                                    ...project.settings.prebuilds,
+                                    triggerStrategy: "webhook-based",
+                                },
+                            },
+                        });
+                        log.info(`Reverted configuration ${project.id} to webhook-based prebuilds`);
+                    }
+
                     await this.webhookEvents.updateEvent(event.id, {
                         authorizedUserId: user.id,
                         projectId: project.id,

components/server/src/prebuilds/github-enterprise-app.ts

@@ -162,6 +162,20 @@ export class GitHubEnterpriseApp {
                 try {
                     const projectOwner = await this.findProjectOwner(project, user);
 
+                    if (project.settings?.prebuilds?.triggerStrategy === "activity-based") {
+                        await this.projectService.updateProject(projectOwner, {
+                            id: project.id,
+                            settings: {
+                                ...project.settings,
+                                prebuilds: {
+                                    ...project.settings.prebuilds,
+                                    triggerStrategy: "webhook-based",
+                                },
+                            },
+                        });
+                        log.info(`Reverted configuration ${project.id} to webhook-based prebuilds`);
+                    }
+
                     await this.webhookEvents.updateEvent(event.id, {
                         authorizedUserId: user.id,
                         projectId: project.id,

components/server/src/prebuilds/gitlab-app.ts

@@ -151,6 +151,20 @@ export class GitLabApp {
                 try {
                     const projectOwner = await this.findProjectOwner(project, user);
 
+                    if (project.settings?.prebuilds?.triggerStrategy === "activity-based") {
+                        await this.projectService.updateProject(projectOwner, {
+                            id: project.id,
+                            settings: {
+                                ...project.settings,
+                                prebuilds: {
+                                    ...project.settings.prebuilds,
+                                    triggerStrategy: "webhook-based",
+                                },
+                            },
+                        });
+                        log.info(`Reverted configuration ${project.id} to webhook-based prebuilds`);
+                    }
+
                     const contextURL = this.createBranchContextUrl(body);
                     log.debug({ userId: user.id }, "GitLab push hook: Context URL", { context: body, contextURL });
                     span.setTag("contextURL", contextURL);

components/server/src/prebuilds/prebuild-manager.ts

@@ -127,10 +127,11 @@ export class PrebuildManager {
     ): Promise<WebhookEvent | undefined> {
         const context = (await this.contextParser.handle(ctx, user, project.cloneUrl)) as CommitContext;
         const maxDepth = 15;
+        const maxAge = 7 * 24 * 60 * 60; // 1 week
 
         const events = await this.webhookEventDb.findByCloneUrl(project.cloneUrl, maxDepth);
         if (events.length === 0) {
-            // return undefined;
+            return undefined;
         }
 
         const hostContext = this.hostContextProvider.get(context.repository.host);
@@ -148,7 +149,15 @@ export class PrebuildManager {
         if (!history) {
             throw new ApplicationError(ErrorCodes.NOT_FOUND, `commit history not found`);
         }
-        const matchingEvent = events.find((event) => history.find((commit) => commit === event.commit));
+        const matchingEvent = events.find((event) =>
+            history.find((commit) => {
+                if (Date.now() - new Date(event.creationTime).getTime() > maxAge) {
+                    return false;
+                }
+
+                return commit === event.commit;
+            }),
+        );
 
         return matchingEvent;
     }