Skip to content

Commit 56adfff

Browse files
authored
[dashboard] don't falsely show image build info (#18446)
1 parent 7f81d83 commit 56adfff

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

components/dashboard/src/start/StartWorkspace.tsx

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -344,7 +344,7 @@ export default class StartWorkspace extends React.Component<StartWorkspaceProps,
344344
return;
345345
}
346346

347-
if (workspaceInstance.status.phase === "building" || workspaceInstance.status.phase === "preparing") {
347+
if (workspaceInstance.status.phase === "building") {
348348
this.setState({ hasImageBuildLogs: true });
349349
}
350350

@@ -460,7 +460,10 @@ export default class StartWorkspace extends React.Component<StartWorkspaceProps,
460460
// Preparing means that we haven't actually started the workspace instance just yet, but rather
461461
// are still preparing for launch.
462462
case "preparing":
463-
// falls through
463+
phase = StartPhase.Preparing;
464+
statusMessage = <p className="text-base text-gray-400">Starting workspace …</p>;
465+
break;
466+
464467
case "building":
465468
// Building means we're building the Docker image for the workspace.
466469
return <ImageBuildView workspaceId={this.state.workspaceInstance.workspaceId} />;

0 commit comments

Comments
 (0)