let workspaces start even on invalid docker refs

Author: filiptronicek

components/server/src/workspace/workspace-factory.ts

@@ -332,6 +332,9 @@ export class WorkspaceFactory {
             if (WorkspaceImageSourceDocker.is(imageSource) && imageSource.dockerFileHash === ImageFileRevisionMissing) {
                 // we let the workspace create here and let it fail to build the image
                 imageSource.dockerFileHash = context.revision;
+                if (imageSource.dockerFileSource) {
+                    imageSource.dockerFileSource.revision = context.revision;
+                }
             }
 
             let projectId: string | undefined;

components/server/src/workspace/workspace-starter.ts

@@ -280,8 +280,12 @@ export class WorkspaceStarter {
                     WorkspaceImageSourceDocker.is(imageSource) &&
                     imageSource.dockerFileHash === ImageFileRevisionMissing
                 ) {
+                    const revision = (workspace.context as CommitContext).revision;
                     // we let the workspace create here and let it fail to build the image
-                    imageSource.dockerFileHash = (workspace.context as CommitContext).revision;
+                    imageSource.dockerFileHash = revision;
+                    if (imageSource.dockerFileSource) {
+                        imageSource.dockerFileSource.revision = revision;
+                    }
                 }
                 log.debug("Found workspace without imageSource, generated one", { imageSource });