Let scan step fail

Author: corneliusludmann

.github/workflows/build.yml

@@ -375,23 +375,23 @@ jobs:
             -DpublishToNPM="${PUBLISH_TO_NPM}" \
             -DnpmPublishTrigger="${NPM_PUBLISH_TRIGGER}" \
             -DpublishToJBMarketplace="${PUBLISH_TO_JBPM}" \
-            -DimageRepoBase=$IMAGE_REPO_BASE
+            -DimageRepoBase=$IMAGE_REPO_BASE || RESULT=$?
 
           {
             echo "leeway_sboms_dir=$sboms_dir"
             echo "leeway_vulnerability_reports_dir=$scans_dir"
           } >> $GITHUB_OUTPUT
 
           cat "$scans_dir/vulnerability-summary.md" >> $GITHUB_STEP_SUMMARY
+
+          exit $RESULT
       - name: Upload SBOMs
         uses: actions/upload-artifact@v4
-        if: success()
         with:
           name: sboms
           path: ${{ steps.scan.outputs.leeway_sboms_dir }}
       - name: Upload vulnerability reports
         uses: actions/upload-artifact@v4
-        if: success()
         with:
           name: vulnerability-reports
           path: ${{ steps.scan.outputs.leeway_vulnerability_reports_dir }}
@@ -593,7 +593,7 @@ jobs:
           SLACK_ICON_EMOJI: ":x:"
           SLACK_USERNAME: "Scheduled Build"
           SLACK_COLOR: "danger"
-          SLACK_MESSAGE: "Daily scheduled build failed! Please check the logs for details."
+          SLACK_MESSAGE: "Daily scheduled build with vulnerability scan failed! Please check the logs for details."
           SLACK_FOOTER: "<${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}|View Workflow Logs>"
 
   delete-runner: