matchesNewWorkspaceIdExactly to handle undefined

Author: filiptronicek

components/gitpod-protocol/src/util/parse-workspace-id.spec.ts

@@ -81,5 +81,9 @@ export class ParseWorkspaceIdTest {
         const actual = matchesNewWorkspaceIdExactly("moccasin-ferret-15599b3");
         expect(actual).to.be.false;
     }
+    @test public matchesWorkspaceIdExactly_new_negative_empty() {
+        const actual = matchesNewWorkspaceIdExactly(undefined);
+        expect(actual).to.be.false;
+    }
 }
 module.exports = new ParseWorkspaceIdTest();

components/gitpod-protocol/src/util/parse-workspace-id.ts

@@ -49,6 +49,10 @@ export const matchesInstanceIdOrLegacyWorkspaceIdExactly = function (maybeId: st
  * @param maybeWorkspaceId
  * @returns
  */
-export const matchesNewWorkspaceIdExactly = function (maybeWorkspaceId: string): boolean {
+export const matchesNewWorkspaceIdExactly = function (maybeWorkspaceId?: string): boolean {
+    if (!maybeWorkspaceId) {
+        return false;
+    }
+
     return REGEX_WORKSPACE_ID_EXACT.test(maybeWorkspaceId);
 };