Skip to content

Commit 8e7678a

Browse files
Log edge case for updateDeletionEligibilityTime (#20354)
1 parent aeaec34 commit 8e7678a

File tree

1 file changed

+14
-2
lines changed

1 file changed

+14
-2
lines changed

components/server/src/workspace/workspace-service.ts

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -538,6 +538,14 @@ export class WorkspaceService {
538538
const lastActive =
539539
instance?.stoppingTime || instance?.startedTime || instance?.creationTime || workspace?.creationTime;
540540
if (!lastActive && !activeNow) {
541+
log.warn(
542+
{ userId, workspaceId },
543+
"[updateDeletionEligibilityTime] No last active time found, skipping update of deletion eligibility time",
544+
{
545+
workspace,
546+
instance,
547+
},
548+
);
541549
return;
542550
}
543551
const deletionEligibilityTime = activeNow ? new Date() : new Date(lastActive);
@@ -567,7 +575,7 @@ export class WorkspaceService {
567575
) {
568576
log.warn(
569577
{ userId, workspaceId, instanceId: instance?.id },
570-
"Prevented moving deletion eligibility time backwards",
578+
"[updateDeletionEligibilityTime] Prevented moving deletion eligibility time backwards",
571579
{
572580
hasGitChanges,
573581
timestamps: new TrustedValue({
@@ -587,7 +595,11 @@ export class WorkspaceService {
587595
deletionEligibilityTime: deletionEligibilityTime.toISOString(),
588596
});
589597
} catch (error) {
590-
log.error({ userId, workspaceId }, "Failed to update deletion eligibility time", error);
598+
log.error(
599+
{ userId, workspaceId },
600+
"[updateDeletionEligibilityTime] Failed to update deletion eligibility time",
601+
error,
602+
);
591603
}
592604
}
593605

0 commit comments

Comments
 (0)