Skip to content

Commit aff357b

Browse files
committed
Fix build issues
Tool: gitpod/catfood.gitpod.cloud
1 parent 0b3eda8 commit aff357b

File tree

2 files changed

+17
-20
lines changed

2 files changed

+17
-20
lines changed

components/dashboard/src/teams/onboarding/WelcomeMessageConfigurationField.tsx

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,10 @@ import { SwitchInputField } from "@podkit/switch/Switch";
1515
import { WelcomeMessageEditorModal } from "./WelcomeMessageEditor";
1616
import { WelcomeMessagePreview } from "./WelcomeMessagePreview";
1717
import { useCallback, useState } from "react";
18-
import { OrganizationSettings } from "@gitpod/public-api/lib/gitpod/v1/organization_pb";
18+
import type {
19+
OnboardingSettings_WelcomeMessage,
20+
OrganizationSettings,
21+
} from "@gitpod/public-api/lib/gitpod/v1/organization_pb";
1922
import { PlainMessage } from "@bufbuild/protobuf";
2023

2124
type Props = {
@@ -32,13 +35,13 @@ export const WelcomeMessageConfigurationField = ({ handleUpdateTeamSettings }: P
3235

3336
const [welcomeMessageEditorOpen, setWelcomeMessageEditorOpen] = useState(false);
3437

35-
const handleToggleWelcomeMessageEnabled = useCallback(
36-
async (enabled: boolean) => {
38+
const handleUpdateWelcomeMessage = useCallback(
39+
async (newSettings: PlainMessage<OnboardingSettings_WelcomeMessage>) => {
3740
await handleUpdateTeamSettings({
3841
onboardingSettings: {
3942
welcomeMessage: {
4043
...settings?.onboardingSettings?.welcomeMessage,
41-
enabled,
44+
...newSettings,
4245
},
4346
recommendedRepositories: settings?.onboardingSettings?.recommendedRepositories ?? [],
4447
},
@@ -76,7 +79,7 @@ export const WelcomeMessageConfigurationField = ({ handleUpdateTeamSettings }: P
7679
}
7780
}
7881

79-
handleToggleWelcomeMessageEnabled(checked);
82+
handleUpdateWelcomeMessage({ enabled: checked });
8083
}}
8184
label=""
8285
/>
@@ -87,7 +90,7 @@ export const WelcomeMessageConfigurationField = ({ handleUpdateTeamSettings }: P
8790
isOwner={isOwner}
8891
isOpen={welcomeMessageEditorOpen}
8992
setIsOpen={setWelcomeMessageEditorOpen}
90-
handleUpdateTeamSettings={handleUpdateTeamSettings}
93+
handleUpdateWelcomeMessage={handleUpdateWelcomeMessage}
9194
settings={settings?.onboardingSettings?.welcomeMessage}
9295
/>
9396

components/dashboard/src/teams/onboarding/WelcomeMessageEditor.tsx

Lines changed: 8 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,7 @@
55
*/
66

77
import { PlainMessage } from "@bufbuild/protobuf";
8-
import {
9-
OnboardingSettings_WelcomeMessage,
10-
OrganizationSettings,
11-
} from "@gitpod/public-api/lib/gitpod/v1/organization_pb";
8+
import type { OnboardingSettings_WelcomeMessage } from "@gitpod/public-api/lib/gitpod/v1/organization_pb";
129
import { Textarea } from "@podkit/forms/TextArea";
1310
import { FormEvent, useCallback, useState } from "react";
1411
import { Modal, ModalBody, ModalFooter, ModalHeader } from "../../components/Modal";
@@ -24,18 +21,15 @@ type Props = {
2421
isLoading: boolean;
2522
isOwner: boolean;
2623
isOpen: boolean;
27-
handleUpdateTeamSettings: (
28-
newSettings: Partial<PlainMessage<OrganizationSettings>>,
29-
options?: { throwMutateError?: boolean },
30-
) => Promise<void>;
24+
handleUpdateWelcomeMessage: (newSettings: PlainMessage<OnboardingSettings_WelcomeMessage>) => Promise<void>;
3125
setIsOpen: (isOpen: boolean) => void;
3226
};
3327
export const WelcomeMessageEditorModal = ({
3428
isLoading,
3529
isOwner,
3630
settings,
3731
isOpen,
38-
handleUpdateTeamSettings,
32+
handleUpdateWelcomeMessage,
3933
setIsOpen,
4034
}: Props) => {
4135
const [message, setMessage] = useState<string | undefined>(settings?.message);
@@ -44,13 +38,13 @@ export const WelcomeMessageEditorModal = ({
4438
const updateWelcomeMessage = useCallback(
4539
async (e: FormEvent) => {
4640
e.preventDefault();
47-
await handleUpdateTeamSettings({
48-
onboardingSettings: {
49-
welcomeMessage: { message, featuredMemberId, enabled: settings?.enabled ?? false },
50-
},
41+
await handleUpdateWelcomeMessage({
42+
message,
43+
featuredMemberId,
44+
enabled: settings?.enabled ?? false,
5145
});
5246
},
53-
[handleUpdateTeamSettings, message, featuredMemberId, settings?.enabled],
47+
[handleUpdateWelcomeMessage, message, featuredMemberId, settings?.enabled],
5448
);
5549

5650
return (

0 commit comments

Comments
 (0)