review comments

Author: geropl

components/server/src/prebuilds/prebuild-manager.ts

@@ -381,7 +381,11 @@ export class PrebuildManager {
                         JSON.stringify(filterPrebuildTasks(config?.tasks));
                     // If there is an existing prebuild that isn't failed and it's based on the current config, we return it here instead of triggering a new prebuild.
                     if (isSameConfig) {
-                        return { prebuildId: existingPB.id, wsid: existingPB.buildWorkspaceId, done: true };
+                        return {
+                            prebuildId: existingPB.id,
+                            wsid: existingPB.buildWorkspaceId,
+                            done: existingPB.state === "available",
+                        };
                     }
                 }
             }
@@ -416,8 +420,11 @@ export class PrebuildManager {
                     true,
                 );
                 if (prebuild) {
-                    // TODO(gpl): Why not "done: prebuild.state === "available""?
-                    return { prebuildId: prebuild.id, wsid: prebuild.buildWorkspaceId, done: true };
+                    return {
+                        prebuildId: prebuild.id,
+                        wsid: prebuild.buildWorkspaceId,
+                        done: prebuild.state === "available",
+                    };
                 }
             }