[context parser] Check current ref for Docker image existence

Author: filiptronicek

components/server/src/azure-devops/azure-file-provider.ts

@@ -34,6 +34,15 @@ export class AzureDevOpsFileProvider implements FileProvider {
     ): Promise<string> {
         const [azOrgId, azProject] = getOrgAndProject(repository.owner);
         const repoName = repository.name;
+        const notFoundError = new Error(
+            `File ${path} does not exist in repository ${repository.owner}/${repository.name}`,
+        );
+        const fileExists =
+            (await this.getFileContent({ repository, revision: revisionOrBranch }, user, path)) !== undefined;
+        if (!fileExists) {
+            throw notFoundError;
+        }
+
         const results = await Promise.allSettled([
             this.azureDevOpsApi.getCommits(user, azOrgId, azProject, repoName, {
                 filterCommit: {
@@ -71,7 +80,7 @@ export class AzureDevOpsFileProvider implements FileProvider {
             }
         }
         // TODO(hw): [AZ] proper handle error
-        throw new Error(`File ${path} does not exist in repository ${repository.owner}/${repository.name}`);
+        throw notFoundError;
     }
 
     public async getFileContent(commit: Commit, user: User, path: string): Promise<MaybeContent> {

components/server/src/bitbucket-server/bitbucket-server-file-provider.ts

@@ -24,20 +24,28 @@ export class BitbucketServerFileProvider implements FileProvider {
         path: string,
     ): Promise<string> {
         const { owner, name, repoKind } = repository;
-
         if (!repoKind) {
             throw new Error("Repo kind is missing.");
         }
+        const notFoundError = new Error(
+            `File ${path} does not exist in repository ${repository.owner}/${repository.name}`,
+        );
+
+        const fileExists =
+            (await this.getFileContent({ repository, revision: revisionOrBranch }, user, path)) !== undefined;
+        if (!fileExists) {
+            throw notFoundError;
+        }
 
-        const result = await this.api.getCommits(user, {
+        const commits = await this.api.getCommits(user, {
             owner,
             repoKind,
             repositorySlug: name,
             query: { limit: 1, path, shaOrRevision: revisionOrBranch },
         });
-        const lastCommit = result.values?.[0]?.id;
+        const lastCommit = commits.values?.[0]?.id;
         if (!lastCommit) {
-            throw new Error(`File ${path} does not exist in repository ${repository.owner}/${repository.name}`);
+            throw notFoundError;
         }
 
         return lastCommit;

components/server/src/github/file-provider.ts

@@ -29,21 +29,29 @@ export class GithubFileProvider implements FileProvider {
         user: User,
         path: string,
     ): Promise<string> {
+        const notFoundError = new Error(
+            `File ${path} does not exist in repository ${repository.owner}/${repository.name}`,
+        );
+        const fileExists =
+            (await this.getFileContent({ repository, revision: revisionOrBranch }, user, path)) !== undefined;
+        if (!fileExists) {
+            throw notFoundError;
+        }
+
         const commits = (
             await this.githubApi.run(user, (gh) =>
                 gh.repos.listCommits({
                     owner: repository.owner,
                     repo: repository.name,
                     sha: revisionOrBranch,
-                    // per_page: 1, // we need just the last one right?
+                    per_page: 1, // we just need the last one
                     path,
                 }),
             )
         ).data;
-
         const lastCommit = commits && commits[0];
         if (!lastCommit) {
-            throw new Error(`File ${path} does not exist in repository ${repository.owner}/${repository.name}`);
+            throw notFoundError;
         }
 
         return lastCommit.sha;
@@ -83,7 +91,7 @@ export class GithubFileProvider implements FileProvider {
             }
             return undefined;
         } catch (err) {
-            log.debug("Failed to get Github file content", err, {
+            log.debug("Failed to get GitHub file content", err, {
                 request: params,
             });
         }

components/server/src/gitlab/file-provider.ts

@@ -29,19 +29,28 @@ export class GitlabFileProvider implements FileProvider {
         user: User,
         path: string,
     ): Promise<string> {
-        const result = await this.gitlabApi.run<GitLab.Commit[]>(user, async (g) => {
-            return g.Commits.all(`${repository.owner}/${repository.name}`, { path, refName: revisionOrBranch });
-        });
+        const notFoundError = new Error(
+            `File ${path} does not exist in repository ${repository.owner}/${repository.name}`,
+        );
 
-        if (GitLab.ApiError.is(result)) {
-            throw result;
+        const fileExists =
+            (await this.getFileContent({ repository, revision: revisionOrBranch }, user, path)) !== undefined;
+        if (!fileExists) {
+            throw notFoundError;
         }
 
-        const lastCommit = result[0];
+        const commitsResult = await this.gitlabApi.run<GitLab.Commit[]>(user, async (g) => {
+            return g.Commits.all(`${repository.owner}/${repository.name}`, { path, refName: revisionOrBranch });
+        });
+        if (GitLab.ApiError.is(commitsResult)) {
+            throw commitsResult;
+        }
 
+        const lastCommit = commitsResult[0];
         if (!lastCommit) {
-            throw new Error(`File ${path} does not exist in repository ${repository.owner}/${repository.name}`);
+            throw notFoundError;
         }
+
         return lastCommit.id;
     }